Source/core/html/shadow/DateTimeEditElement.cpp - Issue 1119663002: Making Unicode character names consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/DateTimeEditElement.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase patch Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/DateTimeEditElement.cpp

diff --git a/Source/core/html/shadow/DateTimeEditElement.cpp b/Source/core/html/shadow/DateTimeEditElement.cpp

index 5fa4258474c7bf6e5c477abc3f009714976ea35e..bfb69226c5af0b8b5c4cd406364450d51748bd89 100644

--- a/Source/core/html/shadow/DateTimeEditElement.cpp

+++ b/Source/core/html/shadow/DateTimeEditElement.cpp

@@ -407,7 +407,7 @@ void DateTimeEditBuilder::visitLiteral(const String& text)

if (m_parameters.locale.isRTL() && text.length()) {

Direction dir = direction(text[0]);

if (dir == SegmentSeparator || dir == WhiteSpaceNeutral || dir == OtherNeutral)

- element->appendChild(Text::create(m_editElement.document(), String(&rightToLeftMark, 1)));

+ element->appendChild(Text::create(m_editElement.document(), String(&rightToLeftMarkCharacter, 1)));

}

element->appendChild(Text::create(m_editElement.document(), text));

m_editElement.fieldsWrapperElement()->appendChild(element);