Source/core/editing/SpellChecker.cpp - Issue 1119663002: Making Unicode character names consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/SpellChecker.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code changes to correct Test Expectation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/SpellChecker.cpp

diff --git a/Source/core/editing/SpellChecker.cpp b/Source/core/editing/SpellChecker.cpp

index f99aaf9bf645c0cff89bdb7fca066ac385c3e3db..97f38597a37e6b8b494fb1048dcc92befb41daca 100644

--- a/Source/core/editing/SpellChecker.cpp

+++ b/Source/core/editing/SpellChecker.cpp

@@ -594,7 +594,7 @@ void SpellChecker::markAndReplaceFor(PassRefPtrWillBeRawPtr<SpellCheckRequest> r

Position caretPosition = frame().selection().end();

selectionOffset = paragraph.offsetTo(caretPosition, ASSERT_NO_EXCEPTION);

restoreSelectionAfterChange = true;

- if (selectionOffset > 0 && (static_cast<unsigned>(selectionOffset) > paragraph.text().length() || paragraph.textCharAt(selectionOffset - 1) == newlineCharacter))

+ if (selectionOffset > 0 && (static_cast<unsigned>(selectionOffset) > paragraph.text().length() || paragraph.textCharAt(selectionOffset - 1) == characterNewline))

adjustSelectionForParagraphBoundaries = true;

if (selectionOffset > 0 && static_cast<unsigned>(selectionOffset) <= paragraph.text().length() && isAmbiguousBoundaryCharacter(paragraph.textCharAt(selectionOffset - 1)))

ambiguousBoundaryOffset = selectionOffset - 1;

« no previous file with comments | « Source/core/editing/ReplaceSelectionCommand.cpp ('k') | Source/core/editing/VisibleSelection.cpp » ('j') | Source/core/paint/BoxPainter.cpp » ('J')