Source/core/editing/ReplaceSelectionCommand.cpp - Issue 1119663002: Making Unicode character names consistent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.cpp

Issue 1119663002: Making Unicode character names consistent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Code changes to correct Test Expectation Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/ReplaceSelectionCommand.cpp

diff --git a/Source/core/editing/ReplaceSelectionCommand.cpp b/Source/core/editing/ReplaceSelectionCommand.cpp

index 3202502be38a5d7667866c73ac5e887eaedfa3dd..43e1ab50e876075a3924d5d1d0026a3cf910f6e3 100644

--- a/Source/core/editing/ReplaceSelectionCommand.cpp

+++ b/Source/core/editing/ReplaceSelectionCommand.cpp

@@ -1299,7 +1299,7 @@ bool ReplaceSelectionCommand::shouldPerformSmartReplace() const

static bool isCharacterSmartReplaceExemptConsideringNonBreakingSpace(UChar32 character, bool previousCharacter)

{

- return isCharacterSmartReplaceExempt(character == noBreakSpace ? ' ' : character, previousCharacter);

+ return isCharacterSmartReplaceExempt(character == characterNoBreakSpace ? ' ' : character, previousCharacter);

}

void ReplaceSelectionCommand::addSpacesForSmartReplace()