[bindings] Remove custom setter used in CSSStyleDeclaration

[bindings] Remove custom setter used in CSSStyleDeclaration

This CL is a first in the series of CSSStyleDeclaration's usage of custom bindings.
Here we migrate the helper methods required from the custom bindings as is.
These duplicate helper functions would be eventually removed from the custom binding as we
finish the removal.

BUG=345519
R=haraken@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194718

[vivekg, 2015-04-30 05:24:02]

vivekg@chromium.org changed reviewers:
+ vivekg@chromium.org

[vivekg, 2015-04-30 05:24:03]

PTAL, thanks.

https://codereview.chromium.org/1119653002/diff/1/Source/core/css/CSSStyleDec...
File Source/core/css/CSSStyleDeclaration.cpp (right):

https://codereview.chromium.org/1119653002/diff/1/Source/core/css/CSSStyleDec...
Source/core/css/CSSStyleDeclaration.cpp:102: static CSSPropertyID
cssPropertyInfo(const String& propertyName, v8::Isolate* isolate)
> Keep this comment.

Done.

https://codereview.chromium.org/1119653002/diff/1/Source/core/css/CSSStyleDec...
Source/core/css/CSSStyleDeclaration.cpp:102: static CSSPropertyID
cssPropertyInfo(const String& propertyName, v8::Isolate* isolate)
> Keep this comment.

Done.

https://codereview.chromium.org/1119653002/diff/1/Source/core/css/CSSStyleDec...
Source/core/css/CSSStyleDeclaration.cpp:123: if (exceptionState.throwIfNeeded())
> Don't we need:
> 
>   if (exceptionState.throwIfNeeded())
>     return false;
> 
> ?

Done.

[haraken, 2015-04-30 05:30:22]

LGTM

https://codereview.chromium.org/1119653002/diff/1/Source/core/css/CSSStyleDec...
File Source/core/css/CSSStyleDeclaration.cpp (right):

https://codereview.chromium.org/1119653002/diff/1/Source/core/css/CSSStyleDec...
Source/core/css/CSSStyleDeclaration.cpp:123: if (exceptionState.throwIfNeeded())

I noticed that exceptionState.throwIfNeeded() is called in the caller side of
anonymousNamedSetter. So we don't need exceptionState.throwIfNeeded() here, but
I'd prefer having exceptionState.throwIfNeeded() for clarity.

[vivekg, 2015-04-30 05:37:08]

On 2015/04/30 at 05:30:22, haraken wrote:
> LGTM
> 
>
https://codereview.chromium.org/1119653002/diff/1/Source/core/css/CSSStyleDec...
> File Source/core/css/CSSStyleDeclaration.cpp (right):
> 
>
https://codereview.chromium.org/1119653002/diff/1/Source/core/css/CSSStyleDec...
> Source/core/css/CSSStyleDeclaration.cpp:123: if
(exceptionState.throwIfNeeded())
> 
> I noticed that exceptionState.throwIfNeeded() is called in the caller side of
anonymousNamedSetter. So we don't need exceptionState.throwIfNeeded() here, but
I'd prefer having exceptionState.throwIfNeeded() for clarity.

Sure, we will keep it here. Thanks.

[vivekg, 2015-04-30 05:37:12]

The CQ bit was checked by vivekg@chromium.org

[commit-bot: I haz the power, 2015-04-30 05:37:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119653002/1

[commit-bot: I haz the power, 2015-04-30 09:52:46]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194718

[vivekg, 2015-05-14 16:28:46]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1145463003/ by vivekg@chromium.org.

The reason for reverting is: Reverting due to the dromeo.jslibstylejquery
regression

BUG=483448
.