Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Side by Side Diff: Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp

Issue 1119653002: [bindings] Remove custom setter used in CSSStyleDeclaration (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/core.gypi » ('j') | Source/core/css/CSSStyleDeclaration.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007-2011 Google Inc. All rights reserved. 2 * Copyright (C) 2007-2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 192 matching lines...) Expand 10 before | Expand all | Expand 10 after
203 RefPtrWillBeRawPtr<CSSValue> cssValue = impl->getPropertyCSSValueInternal(re solvedProperty); 203 RefPtrWillBeRawPtr<CSSValue> cssValue = impl->getPropertyCSSValueInternal(re solvedProperty);
204 if (cssValue) { 204 if (cssValue) {
205 v8SetReturnValueStringOrNull(info, cssValue->cssText(), info.GetIsolate( )); 205 v8SetReturnValueStringOrNull(info, cssValue->cssText(), info.GetIsolate( ));
206 return; 206 return;
207 } 207 }
208 208
209 String result = impl->getPropertyValueInternal(resolvedProperty); 209 String result = impl->getPropertyValueInternal(resolvedProperty);
210 v8SetReturnValueString(info, result, info.GetIsolate()); 210 v8SetReturnValueString(info, result, info.GetIsolate());
211 } 211 }
212 212
213 void V8CSSStyleDeclaration::namedPropertySetterCustom(v8::Local<v8::Name> name, v8::Local<v8::Value> value, const v8::PropertyCallbackInfo<v8::Value>& info)
214 {
215 if (!name->IsString())
216 return;
217 CSSStyleDeclaration* impl = V8CSSStyleDeclaration::toImpl(info.Holder());
218 CSSPropertyID unresolvedProperty = cssPropertyInfo(name.As<v8::String>(), in fo.GetIsolate());
219 if (!unresolvedProperty)
220 return;
221
222 TOSTRING_VOID(V8StringResource<TreatNullAsNullString>, propertyValue, value) ;
223 ExceptionState exceptionState(ExceptionState::SetterContext, getPropertyName (resolveCSSPropertyID(unresolvedProperty)), "CSSStyleDeclaration", info.Holder() , info.GetIsolate());
224 impl->setPropertyInternal(unresolvedProperty, propertyValue, false, exceptio nState);
225
226 if (exceptionState.throwIfNeeded())
227 return;
228
229 v8SetReturnValue(info, value);
230 }
231
232 } // namespace blink 213 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/core/core.gypi » ('j') | Source/core/css/CSSStyleDeclaration.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698