Source/WebCore/dom/Node.cpp - Issue 11196044: Merge 130266 - AX: Heap-use-after-free when deleting a ContainerNode with an AX object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/dom/Node.cpp

Issue 11196044: Merge 130266 - AX: Heap-use-after-free when deleting a ContainerNode with an AX object (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1271/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/WebCore/dom/Node.cpp

===================================================================

--- Source/WebCore/dom/Node.cpp (revision 131770)

+++ Source/WebCore/dom/Node.cpp (working copy)

@@ -414,7 +414,7 @@

detach();

Document* doc = m_document;

- if (AXObjectCache::accessibilityEnabled() && doc && doc->axObjectCacheExists())

+ if (AXObjectCache::accessibilityEnabled() && doc && doc->axObjectCacheExists() && !isContainerNode())

doc->axObjectCache()->remove(this);

if (m_previous)

« no previous file with comments | « Source/WebCore/dom/Node.h ('k') | no next file » | no next file with comments »