Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: Source/WebCore/dom/Node.cpp

Issue 11196044: Merge 130266 - AX: Heap-use-after-free when deleting a ContainerNode with an AX object (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/1271/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/WebCore/dom/Node.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 6 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 7 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 396 matching lines...) Expand 10 before | Expand all | Expand 10 after
407 liveNodeSet.remove(this); 407 liveNodeSet.remove(this);
408 #endif 408 #endif
409 409
410 if (hasRareData()) 410 if (hasRareData())
411 clearRareData(); 411 clearRareData();
412 412
413 if (renderer()) 413 if (renderer())
414 detach(); 414 detach();
415 415
416 Document* doc = m_document; 416 Document* doc = m_document;
417 if (AXObjectCache::accessibilityEnabled() && doc && doc->axObjectCacheExists ()) 417 if (AXObjectCache::accessibilityEnabled() && doc && doc->axObjectCacheExists () && !isContainerNode())
418 doc->axObjectCache()->remove(this); 418 doc->axObjectCache()->remove(this);
419 419
420 if (m_previous) 420 if (m_previous)
421 m_previous->setNextSibling(0); 421 m_previous->setNextSibling(0);
422 if (m_next) 422 if (m_next)
423 m_next->setPreviousSibling(0); 423 m_next->setPreviousSibling(0);
424 424
425 if (doc) 425 if (doc)
426 doc->guardDeref(); 426 doc->guardDeref();
427 427
(...skipping 2400 matching lines...) Expand 10 before | Expand all | Expand 10 after
2828 node->showTreeForThis(); 2828 node->showTreeForThis();
2829 } 2829 }
2830 2830
2831 void showNodePath(const WebCore::Node* node) 2831 void showNodePath(const WebCore::Node* node)
2832 { 2832 {
2833 if (node) 2833 if (node)
2834 node->showNodePathForThis(); 2834 node->showNodePathForThis();
2835 } 2835 }
2836 2836
2837 #endif 2837 #endif
OLDNEW
« no previous file with comments | « Source/WebCore/dom/Node.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698