Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 11196014: Revert "cc: Switch to Chromium DCHECKs LOGs" (Closed)

Created:
8 years, 2 months ago by mattm
Modified:
8 years, 2 months ago
Reviewers:
danakj
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Revert "cc: Switch to Chromium DCHECKs LOGs" This reverts commit 162296. (https://chromiumcodereview.appspot.com/11048044) TBR=danakj@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162297

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+697 lines, -760 lines) Patch
M cc/DEPS View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/animation_curve.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M cc/caching_bitmap_canvas_layer_texture_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/cc.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M cc/checkerboard_draw_quad.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/completion_event.h View 5 chunks +8 lines, -9 lines 0 comments Download
M cc/damage_tracker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
D cc/dcheck.h View 1 chunk +0 lines, -18 lines 0 comments Download
M cc/debug_border_draw_quad.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/debug_rect_history.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/delay_based_time_source.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M cc/delegated_renderer_layer_impl.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M cc/direct_renderer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/draw_quad.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M cc/font_atlas.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/frame_rate_controller.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M cc/frame_rate_counter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M cc/gl_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/gl_renderer.cc View 32 chunks +47 lines, -41 lines 0 comments Download
M cc/gl_renderer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/heads_up_display_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/io_surface_draw_quad.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/keyframed_animation_curve.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/layer_animation_controller.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/layer_impl.h View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/layer_impl.cc View 4 chunks +13 lines, -11 lines 0 comments Download
M cc/layer_iterator.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_quad.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/layer_sorter.cc View 12 chunks +32 lines, -25 lines 0 comments Download
M cc/layer_texture_sub_image.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tiling_data.cc View 3 chunks +2 lines, -4 lines 0 comments Download
M cc/layer_tree_host.cc View 13 chunks +17 lines, -17 lines 0 comments Download
M cc/layer_tree_host_common.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M cc/layer_tree_host_common_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layer_tree_host_impl.cc View 20 chunks +28 lines, -28 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M cc/layer_tree_host_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M cc/math_util.h View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/math_util.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/occlusion_tracker.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M cc/occlusion_tracker_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/platform_color.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/prioritized_texture.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/prioritized_texture.cc View 9 chunks +23 lines, -21 lines 0 comments Download
M cc/prioritized_texture_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/prioritized_texture_manager.cc View 19 chunks +50 lines, -50 lines 0 comments Download
M cc/prioritized_texture_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/program_binding.h View 3 chunks +4 lines, -6 lines 0 comments Download
M cc/program_binding.cc View 6 chunks +13 lines, -12 lines 0 comments Download
M cc/proxy.h View 4 chunks +6 lines, -7 lines 0 comments Download
M cc/proxy.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/quad_culler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/rate_limiter.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/render_pass.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/render_pass_draw_quad.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M cc/render_surface_filters.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/render_surface_impl.cc View 6 chunks +5 lines, -6 lines 0 comments Download
M cc/resource_provider.cc View 26 chunks +61 lines, -61 lines 0 comments Download
M cc/resource_provider_unittest.cc View 10 chunks +37 lines, -38 lines 0 comments Download
M cc/scheduler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M cc/scheduler_state_machine.cc View 8 chunks +11 lines, -11 lines 0 comments Download
M cc/scheduler_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/scoped_ptr_hash_map.h View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/scoped_ptr_vector.h View 5 chunks +6 lines, -7 lines 0 comments Download
M cc/scoped_texture.h View 2 chunks +2 lines, -3 lines 0 comments Download
M cc/scoped_texture.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/scoped_thread_proxy.h View 4 chunks +4 lines, -5 lines 0 comments Download
M cc/scrollbar_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/shader.cc View 17 chunks +16 lines, -17 lines 0 comments Download
M cc/single_thread_proxy.h View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/single_thread_proxy.cc View 14 chunks +24 lines, -24 lines 0 comments Download
M cc/software_renderer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/solid_color_draw_quad.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/stream_video_draw_quad.cc View 2 chunks +1 line, -3 lines 0 comments Download
D cc/stubs/config.h View 1 chunk +0 lines, -17 lines 0 comments Download
M cc/stubs/trace_event.h View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/test/fake_web_compositor_output_surface.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/test/fake_web_compositor_software_output_device.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/test/scheduler_test_common.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/scheduler_test_common.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/texture_copier.cc View 1 chunk +1 line, -1 line 0 comments Download
cc/texture_draw_quad.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/texture_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/thread_proxy.cc View 40 chunks +70 lines, -70 lines 0 comments Download
M cc/threaded_unittest.cc View 11 chunks +12 lines, -12 lines 0 comments Download
M cc/throttled_texture_uploader.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/tile_draw_quad.cc View 2 chunks +1 line, -3 lines 0 comments Download
cc/tiled_layer.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M cc/tiled_layer_impl.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/tiled_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/timer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M cc/tree_synchronizer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/unthrottled_texture_uploader.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/video_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
cc/video_layer_impl.cc View 6 chunks +13 lines, -13 lines 0 comments Download
M cc/yuv_video_draw_quad.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
mattm
Seems to have caused two different errors: 1. Compile fail: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/43608/steps/compile/logs/stdio#error1 In file included from ...
8 years, 2 months ago (2012-10-17 01:28:23 UTC) #1
mattm
8 years, 2 months ago (2012-10-17 01:44:11 UTC) #2
Also:
http://build.chromium.org/p/chromium.win/builders/Win%20Builder%202008%20%28d...

________ running 'C:\b\depot_tools\python_bin\python.exe src/build/gyp_chromium'
in 'C:\b\build\slave\cr-win-2008-dbg\build'
Enabled Psyco JIT.
Updating projects from gyp files...
Traceback (most recent call last):
  File "src/build/gyp_chromium", line 175, in <module>
    sys.exit(gyp.main(args))
  File
"C:\b\build\slave\cr-win-2008-dbg\build\src\tools\gyp\pylib\gyp\__init__.py",
line 523, in main
    return gyp_main(args)
  File
"C:\b\build\slave\cr-win-2008-dbg\build\src\tools\gyp\pylib\gyp\__init__.py",
line 508, in gyp_main
    generator.GenerateOutput(flat_list, targets, data, params)
  File
"C:\b\build\slave\cr-win-2008-dbg\build\src\tools\gyp\pylib\gyp\generator\msvs.py",
line 1875, in GenerateOutput
    raise Exception(error_message)
Exception: Missing input files:
C:\b\build\slave\cr-win-2008-dbg\build\src\cc\stubs\config.hstubs\extensions_3d_chromium.h
Error: Command C:\b\depot_tools\python_bin\python.exe src/build/gyp_chromium
returned non-zero exit status 1 in C:\b\build\slave\cr-win-2008-dbg\build
program finished with exit code 2
elapsedTime=51.184000

Powered by Google App Engine
This is Rietveld 408576698