Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 1119483003: Revert of [turbofan] add MachineType to AllocatedOperand (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
Reviewers:
dcarney, Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] add MachineType to AllocatedOperand (patchset #17 id:310001 of https://codereview.chromium.org/1087793002/) Reason for revert: [Sheriff] Breaks compile on chromium asan and v8 msan: http://build.chromium.org/p/client.v8/builders/Linux%20ASAN%20Builder/builds/3446 http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/2085 Original issue's description: > [turbofan] add MachineType to AllocatedOperand > > - allows the optimization of emitted gap move code since the representation of the value in the register is known > - necessary preparation for vector register allocation > - prepare for slot sharing for any value of the same byte width > > BUG= > > Committed: https://crrev.com/3a025d1ab6437559f86a464767aa03d2d9789f6f > Cr-Commit-Position: refs/heads/master@{#28137} TBR=jarin@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/7eccb1814829a8db3b14d1c061ade19869bd75b5 Cr-Commit-Position: refs/heads/master@{#28139}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -536 lines) Patch
M src/compiler/frame.h View 3 chunks +12 lines, -7 lines 0 comments Download
M src/compiler/gap-resolver.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction.h View 13 chunks +34 lines, -96 lines 0 comments Download
M src/compiler/instruction.cc View 5 chunks +33 lines, -83 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +12 lines, -5 lines 0 comments Download
M src/compiler/instruction-selector.cc View 5 chunks +123 lines, -70 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/move-optimizer.cc View 3 chunks +5 lines, -18 lines 0 comments Download
M src/compiler/register-allocator.h View 13 chunks +20 lines, -29 lines 0 comments Download
M src/compiler/register-allocator.cc View 32 chunks +90 lines, -173 lines 0 comments Download
M src/compiler/register-allocator-verifier.cc View 5 chunks +12 lines, -13 lines 0 comments Download
M test/cctest/compiler/test-gap-resolver.cc View 3 chunks +6 lines, -27 lines 0 comments Download
M test/cctest/compiler/test-instruction.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/compiler/test-jump-threading.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M test/unittests/compiler/instruction-selector-unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/unittests/compiler/move-optimizer-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [turbofan] add MachineType to AllocatedOperand
5 years, 7 months ago (2015-04-29 18:28:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119483003/1
5 years, 7 months ago (2015-04-29 18:28:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-29 18:28:44 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-04-29 18:28:55 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7eccb1814829a8db3b14d1c061ade19869bd75b5
Cr-Commit-Position: refs/heads/master@{#28139}

Powered by Google App Engine
This is Rietveld 408576698