Issue 11194068: Linux: fix build with system zlib.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11194068: Linux: fix build with system zlib. (Closed)

Created:
8 years, 2 months ago by Paweł Hajdan Jr.

Modified:
8 years, 2 months ago

Reviewers:
James Hawkins, agl

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Linux: fix build with system zlib. This CL disables both the workaround for http://crbug.com/139744 and SPDY compression when using system zlib. Google Chrome should not be affected by this change (bundled patched zlib still used, as well as compression). This also fixes another uncovered problem with system minizip. BUG=29048 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162911

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -0 lines)			Patch
M	chrome/chrome_browser.gypi	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/zip_reader.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/http/infinite_cache.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View	4 chunks	+29 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	6 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Please review: agl: net/ jhawkins: chrome (note a very similar change landed recently, https://codereview.chromium.org/11214002)

8 years, 2 months ago (2012-10-18 22:25:26 UTC) #1

James Hawkins

On 2012/10/18 22:25:26, Paweł Hajdan Jr. wrote: > Please review: > > agl: net/ > ...

8 years, 2 months ago (2012-10-18 22:26:38 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/11194068/1

8 years, 2 months ago (2012-10-19 00:00:49 UTC) #4

Change committed as 162911

Expand Messages | Collapse Messages