Issue 11214002: Linux: add an option to use system minizip.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11214002: Linux: add an option to use system minizip. (Closed)

Created:
8 years, 2 months ago by Paweł Hajdan Jr.

Modified:
8 years, 2 months ago

Reviewers:
Nico

CC:
chromium-reviews, brettw, Aaron Boodman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Linux: add an option to use system minizip. This is helpful for Linux distros, I've tested this CL on Gentoo Linux. Google Chrome defaults to bundled minizip, so no change here. BUG=29048 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162750

Patch Set 1 #

Patch Set 2 : fixes #

Patch Set 3 : more fixes for clang etc #

Total comments: 2

Patch Set 4 : style nit #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -16 lines)			Patch
M	chrome/chrome_common.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/zip.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/common/zip_internal.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/common/zip_internal.cc	View		1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/common/zip_reader.cc	View		1 chunk	+6 lines, -1 line	0 comments	Download
M	third_party/zlib/zlib.gyp	View	1 2 3	5 chunks	+40 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Paweł Hajdan Jr.

Nico: please review; hopefully no functional change in default configuration Brett, Aaron: FYI, I think ...

8 years, 2 months ago (2012-10-17 20:42:30 UTC) #1

Nico

gyp changes lgtm, but I have no idea if 'minizip' is something that's commonly packaged ...

8 years, 2 months ago (2012-10-18 18:47:09 UTC) #2

Paweł Hajdan Jr.

8 years, 2 months ago (2012-10-18 18:55:22 UTC) #3

https://codereview.chromium.org/11214002/diff/7001/third_party/zlib/zlib.gyp
File third_party/zlib/zlib.gyp (right):

https://codereview.chromium.org/11214002/diff/7001/third_party/zlib/zlib.gyp#...
third_party/zlib/zlib.gyp:111: }], ['OS=="android"', {
On 2012/10/18 18:47:09, Nico wrote:
> newline after the first , (I realize you're jsut moving this around)

Done.

Expand Messages | Collapse Messages