Issue 1119403003: Propagate failures from VirtualMemory::Commit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1119403003: Propagate failures from VirtualMemory::Commit. (Closed)

Created:
5 years, 7 months ago by koda

Modified:
5 years, 7 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/trunk/dart/

Visibility:
Public.

More Reviews

Description

Propagate failures from VirtualMemory::Commit. BUG=23314 R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=45501

Patch Set 4 : #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -4 lines)			Patch
M	runtime/vm/pages.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/pages.cc	View	1 2	2 chunks	+11 lines, -3 lines	0 comments	Download
M	runtime/vm/virtual_memory.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM once unreserving. -Ivan https://codereview.chromium.org/1119403003/diff/20001/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/1119403003/diff/20001/runtime/vm/pages.cc#newcode52 runtime/vm/pages.cc:52: return NULL; We should unreserve ...

5 years, 7 months ago (2015-05-04 18:16:03 UTC) #2

koda

https://codereview.chromium.org/1119403003/diff/20001/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/1119403003/diff/20001/runtime/vm/pages.cc#newcode52 runtime/vm/pages.cc:52: return NULL; On 2015/05/04 18:16:02, Ivan Posva wrote: > ...

5 years, 7 months ago (2015-05-04 18:19:09 UTC) #3

koda

Committed patchset #4 (id:60001) manually as r45501 (presubmit successful).

5 years, 7 months ago (2015-05-04 18:35:59 UTC) #4

ricow1

5 years, 7 months ago (2015-05-04 19:16:27 UTC) #5

Message was sent while issue was closed.

On 2015/05/04 18:35:59, koda wrote:
> Committed patchset #4 (id:60001) manually as r45501 (presubmit successful).

This is on trunk!!!

Expand Messages | Collapse Messages

Issue 1119403003: Propagate failures from VirtualMemory::Commit. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages