Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: utils/pub/io.dart

Issue 11194025: Second round of cleanups for new optional parameter semantics. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/pub/io.dart
===================================================================
--- utils/pub/io.dart (revision 13712)
+++ utils/pub/io.dart (working copy)
@@ -331,7 +331,7 @@
// TODO(rnystrom): Remove this when old style packages are no longer supported.
// See: http://code.google.com/p/dart/issues/detail?id=4964.
Future<File> createPackageSymlink(String name, from, to,
- [bool isSelfLink = false]) {
+ {bool isSelfLink: false}) {
// If from contains any Dart files at the top level (aside from build.dart)
// we assume that means it's an old style package.
return listDir(from).chain((contents) {
@@ -449,7 +449,7 @@
* [onClosed] is called when [source] is closed.
*/
void pipeInputToInput(InputStream source, ListInputStream sink,
- [void onClosed()]) {
+ {void onClosed()}) {
Bob Nystrom 2012/10/17 16:21:38 Make this positional please.
regis 2012/10/17 19:58:16 Done.
source.onClosed = () {
sink.markEndOfStream();
if (onClosed != null) onClosed();
« tests/compiler/dart2js/redundant_phi_eliminator_test.dart ('K') | « utils/pub/git_source.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698