Second round of cleanups for new optional parameter semantics.

utils/pub/io.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * Helper functionality to make working with IO easier.
  */
 library io;
 
 import 'dart:io';
@@ skipping 313 matching lines @@
  *
  * Unlike [createSymlink], this has heuristics to detect if [from] is using
  * the old or new style of package layout. If it's using the new style, then
  * it will create a symlink to the "lib" directory contained inside that
  * package directory. Otherwise, it just symlinks to the package directory
  * itself.
  */
 // TODO(rnystrom): Remove this when old style packages are no longer supported.
 // See: http://code.google.com/p/dart/issues/detail?id=4964.
 Future<File> createPackageSymlink(String name, from, to,
-    [bool isSelfLink = false]) {
+    {bool isSelfLink: false}) {
   // If from contains any Dart files at the top level (aside from build.dart)
   // we assume that means it's an old style package.
   return listDir(from).chain((contents) {
     var isOldStyle = contents.some(
         (file) => file.endsWith('.dart') && basename(file) != 'build.dart');
 
     if (isOldStyle) {
       if (isSelfLink) {
         printError('Warning: Package "$name" is using a deprecated layout.');
         printError('See http://www.dartlang.org/docs/pub-package-manager/'
@@ skipping 97 matching lines @@
       .transform((bytes) => new String.fromCharCodes(bytes));
   return timeout(future, HTTP_TIMEOUT, 'Timed out while fetching URL "$uri".');
 }
 
 /**
  * Takes all input from [source] and writes it to [sink].
  *
  * [onClosed] is called when [source] is closed.
  */
 void pipeInputToInput(InputStream source, ListInputStream sink,
-    [void onClosed()]) {
+    {void onClosed()}) {

[Bob Nystrom, 2012/10/17 16:21:38]

Make this positional please.

[regis, 2012/10/17 19:58:16]

Done.

   source.onClosed = () {
     sink.markEndOfStream();
     if (onClosed != null) onClosed();
   };
   source.onData = () => sink.write(source.read());
   // TODO(nweiz): propagate this error to the sink. See issue 3657.
   source.onError = (e) { throw e; };
 }
 
 /**
@@ skipping 292 matching lines @@
   return new Directory(entry);
 }
 
 /**
  * Gets a [Uri] for [uri], which can either already be one, or be a [String].
  */
 Uri _getUri(uri) {
   if (uri is Uri) return uri;
   return new Uri.fromString(uri);
 }