Issue 11194022: Revert 162226 - Add common_resources.grd for non-localizeable chromoting resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11194022: Revert 162226 - Add common_resources.grd for non-localizeable chromoting resources. (Closed)

Created:
8 years, 2 months ago by ericu

Modified:
8 years, 2 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 162226 - Add common_resources.grd for non-localizeable chromoting resources. Error: /b/build/slave/Mac/build/src/remoting/base/resources_unittest.cc:8:10: fatalerror: 'remoting/base/string_resources.h' file not found #include "remoting/base/string_resources.h" ^ 1 error generated. The new common_resources.grd will be used for non-loalizeable resources, such as images. Review URL: https://chromiumcodereview.appspot.com/11087059 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162277

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -104 lines)			Patch
M	remoting/base/resources.cc	View	1 chunk	+2 lines, -10 lines	0 comments	Download
M	remoting/base/resources_unittest.cc	View	2 chunks	+3 lines, -22 lines	0 comments	Download
D	remoting/grit_action.gypi	View	1 chunk	+0 lines, -31 lines	0 comments	Download
M	remoting/remoting.gyp	View	1 chunk	+18 lines, -20 lines	0 comments	Download
D	remoting/resources/common_resources.grd	View	1 chunk	+0 lines, -18 lines	0 comments	Download
M	remoting/resources/resource_ids	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages