Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: remoting/base/resources_unittest.cc

Issue 11194022: Revert 162226 - Add common_resources.grd for non-localizeable chromoting resources. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/base/resources.cc ('k') | remoting/grit_action.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/base/resources_unittest.cc
===================================================================
--- remoting/base/resources_unittest.cc (revision 162276)
+++ remoting/base/resources_unittest.cc (working copy)
@@ -4,7 +4,6 @@
#include "remoting/base/resources.h"
-#include "remoting/base/common_resources.h"
#include "remoting/base/string_resources.h"
#include "ui/base/l10n/l10n_util.h"
#include "ui/base/resource/resource_bundle.h"
@@ -16,37 +15,19 @@
// the test.
#if !defined(OS_MACOSX)
#define MAYBE_ProductName ProductName
-#define MAYBE_ProductLogo ProductLogo
#else // !defined(OS_MACOSX)
#define MAYBE_ProductName DISABLED_ProductName
-#define MAYBE_ProductLogo DISABLED_ProductLogo
#endif // defined(OS_MACOSX)
-
-class ResourcesTest : public testing::Test {
- protected:
- void SetUp() OVERRIDE {
- ASSERT_TRUE(LoadResources("en-US"));
- }
-
- void TearDown() OVERRIDE {
- ui::ResourceBundle::CleanupSharedInstance();
- }
-};
-
-TEST_F(ResourcesTest, MAYBE_ProductName) {
+TEST(Resources, MAYBE_ProductName) {
#if defined(GOOGLE_CHROME_BUILD)
std::string expected_product_name = "Chrome Remote Desktop";
#else // defined(GOOGLE_CHROME_BUILD)
std::string expected_product_name = "Chromoting";
#endif // !defined(GOOGLE_CHROME_BUILD)
+ ASSERT_TRUE(LoadResources("en-US"));
EXPECT_EQ(expected_product_name,
l10n_util::GetStringUTF8(IDR_REMOTING_PRODUCT_NAME));
+ ui::ResourceBundle::CleanupSharedInstance();
}
-TEST_F(ResourcesTest, MAYBE_ProductLogo) {
- gfx::Image logo = ui::ResourceBundle::GetSharedInstance().GetImageNamed(
- IDR_PRODUCT_LOGO_16);
- EXPECT_FALSE(logo.IsEmpty());
-}
-
} // namespace remoting
« no previous file with comments | « remoting/base/resources.cc ('k') | remoting/grit_action.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698