Chromium Code Reviews
Help | Chromium Project | Sign in
(113)

Issue 11192027: drive: Fix computation for showing the number of fetched files (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 8 months ago by satorux1
Modified:
2 years, 8 months ago
Reviewers:
hidehiko, hashimoto
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Fix computation for showing the number of fetched files Previously, computation of the interval resulted in a negative value in under certain circumstances, which resulted in a DCHECK failure. This patch fixes the problem. BUG=154363 TEST=Log in using a large Drive account; open Files.app and go to Drive; The number of fetched files was updated smoothly Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=162361

Patch Set 1 : polish #

Total comments: 4

Patch Set 2 : address comments #

Total comments: 2

Patch Set 3 : polish #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc View 1 2 2 chunks +10 lines, -3 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 14 (0 generated)
satorux1
2 years, 8 months ago (2012-10-17 05:52:02 UTC) #1
hidehiko
http://codereview.chromium.org/11192027/diff/2001/chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc File chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc (right): http://codereview.chromium.org/11192027/diff/2001/chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc#newcode759 chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc:759: ui_state->last_fetch_time - ui_state ->start_time; s/ui_state ->/ui_state->/ http://codereview.chromium.org/11192027/diff/2001/chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc#newcode764 chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc:764: const ...
2 years, 8 months ago (2012-10-17 06:26:41 UTC) #2
satorux1
http://codereview.chromium.org/11192027/diff/2001/chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc File chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc (right): http://codereview.chromium.org/11192027/diff/2001/chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc#newcode759 chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc:759: ui_state->last_fetch_time - ui_state ->start_time; On 2012/10/17 06:26:41, hidehiko wrote: ...
2 years, 8 months ago (2012-10-17 08:00:43 UTC) #3
satorux1
PTAL. The code is almost back to the original. The negative case is handled safely.
2 years, 8 months ago (2012-10-17 08:34:52 UTC) #4
hidehiko
http://codereview.chromium.org/11192027/diff/6001/chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc File chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc (right): http://codereview.chromium.org/11192027/diff/6001/chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc#newcode766 chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc:766: if (interval.InMilliseconds() < 0) 10 instead of 0 may ...
2 years, 8 months ago (2012-10-17 08:39:49 UTC) #5
satorux1
http://codereview.chromium.org/11192027/diff/6001/chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc File chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc (right): http://codereview.chromium.org/11192027/diff/6001/chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc#newcode766 chrome/browser/chromeos/drive/gdata_wapi_feed_loader.cc:766: if (interval.InMilliseconds() < 0) On 2012/10/17 08:39:49, hidehiko wrote: ...
2 years, 8 months ago (2012-10-17 08:44:03 UTC) #6
hidehiko
lgtm
2 years, 8 months ago (2012-10-17 08:45:27 UTC) #7
satorux1
On 2012/10/17 08:45:27, hidehiko wrote: > lgtm I changed my mind. You were right that ...
2 years, 8 months ago (2012-10-17 08:49:36 UTC) #8
hidehiko
lgtm
2 years, 8 months ago (2012-10-17 09:10:33 UTC) #9
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
2 years, 8 months ago (2012-10-17 09:16:03 UTC) #10
satorux1
2 years, 8 months ago (2012-10-17 09:16:21 UTC) #11
hashimoto
lgtm
2 years, 8 months ago (2012-10-17 09:29:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/11192027/10001
2 years, 8 months ago (2012-10-17 09:45:14 UTC) #13
commit-bot: I haz the power
2 years, 8 months ago (2012-10-17 12:30:52 UTC) #14
Change committed as 162361
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d