bluetooth: Initial JNI setup for device/bluetooth.

device/bluetooth/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//tools/grit/grit_rule.gni")
 
 config("bluetooth_config") {
   if (is_win) {
     ldflags = [
       "/DELAYLOAD:BluetoothApis.dll",
@@ skipping 105 matching lines @@
   all_dependent_configs = [ ":bluetooth_config" ]
 
   deps = [
     ":strings",
     "uribeacon",
     "//base",
     "//net",
     "//ui/base",
   ]
 
-  if (is_win) {
-    libs = [ "setupapi.lib" ]
-  } else if (is_chromeos) {
+  if (is_android) {
+    deps += [
+      "//device/bluetooth/android",
+      "//device/bluetooth/android:bluetooth_jni",
+    ]
+    allow_circular_includes_from = [ "//device/bluetooth/android" ]

[cjhopman, 2015/05/06 16:56:14]

It looks like you need this because you have the jni stuff generated from the
java BluetoothAdapter being implemented/registered in
bluetooth_adapter_android.cc. I would maybe add something like a
java_bluetooth_adapter.h/.cc (or maybe bluetooth_adapter_jni.h/.cc) in android/
that did that and then you wouldn't need to allow circular includes.

[timvolodine, 2015/05/06 17:27:10]

+1 if you can avoid 'allow_circular_includes'. I don't remember needing that in
the vibration patch.

[cjhopman, 2015/05/06 17:51:20]

It does look like the vibration change introduces an include from
device/vibration/android to device/vibration. That violates the dependency
relationship, but there's no existing include from device/vibration to
device/vibration/android and so there's no circular includes.

That include without a corresponding dep caused build failures and required this
change: https://codereview.chromium.org/826593003 (which doesn't actually add
the real dep because that would cause a dependency cycle).

[scheib, 2015/05/06 19:14:07]

I've merged the GN files, with just one target this is no longer an issue.

+  }
+
+  if (is_chromeos) {
     deps += [
       "//chromeos",
       "//dbus",
     ]
   }
 
   if (is_mac) {
     libs = [ "IOBluetooth.framework" ]
   }
+
+  if (is_win) {
+    libs = [ "setupapi.lib" ]
+  }
 }
 
 grit("strings") {
   source = "bluetooth_strings.grd"
   outputs = [
     "grit/device_bluetooth_strings.h",
     "device_bluetooth_strings_am.pak",
     "device_bluetooth_strings_ar.pak",
     "device_bluetooth_strings_bg.pak",
     "device_bluetooth_strings_bn.pak",
@@ skipping 73 matching lines @@
     "test/mock_bluetooth_socket.h",
   ]
 
   deps = [
     ":bluetooth",
     "//base",
     "//net",
     "//testing/gmock",
   ]
 }