Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 826593003: Fix android gn builds. (Closed)

Created:
5 years, 12 months ago by Nico
Modified:
5 years, 12 months ago
Reviewers:
eroman, dcheng
CC:
brettw, chromium-reviews, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix android gn builds. android_chromium_gn_compile_dbg is red failing to compile a cc file: In file included from ../../device/vibration/android/vibration_jni_registrar.cc:9:0: ../../device/vibration/vibration_manager_impl_android.h:9:54: fatal error: device/vibration/vibration_manager.mojom.h: No such file or directory #include "device/vibration/vibration_manager.mojom.h" ^ This was added with incorrect dependencies in https://codereview.chromium.org/583663003/ two weeks ago, but apparently no clobber happened since then. The problem can be reproduced locally by running rm -rf out/Debug gn gen out/Debug --args=is_debug=true\ os=\"android\"\ cpu_arch=\"arm\"\ use_goma=true\ goma_dir=\"$HOME/goma\" ninja -C out/Debug obj/device/vibration/android/android.vibration_jni_registrar.o BUG=none R=dcheng@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/fc38eeb37ff940849dd4e577b5e20b6598f38859

Patch Set 1 #

Total comments: 2

Patch Set 2 : typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M device/vibration/android/BUILD.gn View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
(Brett: Looks like mojom stuff isn't foolproof in gn either :-/)
5 years, 12 months ago (2014-12-24 00:29:25 UTC) #2
dcheng
lgtm
5 years, 12 months ago (2014-12-24 00:30:08 UTC) #3
eroman
https://codereview.chromium.org/826593003/diff/1/device/vibration/android/BUILD.gn File device/vibration/android/BUILD.gn (right): https://codereview.chromium.org/826593003/diff/1/device/vibration/android/BUILD.gn#newcode17 device/vibration/android/BUILD.gn:17: # vibration_jni_registrar.cc includes a header form device/vibration form -> ...
5 years, 12 months ago (2014-12-24 00:30:55 UTC) #5
Nico
https://codereview.chromium.org/826593003/diff/1/device/vibration/android/BUILD.gn File device/vibration/android/BUILD.gn (right): https://codereview.chromium.org/826593003/diff/1/device/vibration/android/BUILD.gn#newcode17 device/vibration/android/BUILD.gn:17: # vibration_jni_registrar.cc includes a header form device/vibration On 2014/12/24 ...
5 years, 12 months ago (2014-12-24 00:32:30 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/fc38eeb37ff940849dd4e577b5e20b6598f38859 Cr-Commit-Position: refs/heads/master@{#309591}
5 years, 12 months ago (2014-12-24 00:37:10 UTC) #7
Nico
5 years, 12 months ago (2014-12-24 00:37:17 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fc38eeb37ff940849dd4e577b5e20b6598f38859.

Powered by Google App Engine
This is Rietveld 408576698