Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 11190016: Do not add TabContents from packaged apps to the task manager. (Closed)

Created:
8 years, 2 months ago by tapted
Modified:
8 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, yoshiki+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Do not add TabContents from packaged apps to the task manager. Moves the existing is_app check for TabContents (for determining title prefix) to the Observe(..) that would have otherwise added it. BUG=144936 TEST=Start Task manager, Start App (e.g. Hello World)

Patch Set 1 #

Total comments: 1

Patch Set 2 : Preserve behaviour for non-platform apps #

Patch Set 3 : Add a unit test for PlatformApps in the TaskManager #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -30 lines) Patch
M chrome/browser/extensions/extension_browsertest.h View 1 2 3 2 chunks +16 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.cc View 1 2 3 5 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest_util.h View 1 2 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/extensions/platform_app_browsertest_util.cc View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/task_manager/task_manager_browsertest.cc View 1 2 3 chunks +82 lines, -0 lines 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 3 3 chunks +30 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
benwells
https://codereview.chromium.org/11190016/diff/1/chrome/browser/task_manager/task_manager_resource_providers.cc File chrome/browser/task_manager/task_manager_resource_providers.cc (right): https://codereview.chromium.org/11190016/diff/1/chrome/browser/task_manager/task_manager_resource_providers.cc#newcode509 chrome/browser/task_manager/task_manager_resource_providers.cc:509: process_map->Contains(web_contents->GetRenderProcessHost()->GetID()); I don't think this will work with old ...
8 years, 2 months ago (2012-10-17 05:59:49 UTC) #1
benwells
8 years, 1 month ago (2012-11-05 05:11:21 UTC) #2
On 2012/10/17 05:59:49, benwells wrote:
>
https://codereview.chromium.org/11190016/diff/1/chrome/browser/task_manager/t...
> File chrome/browser/task_manager/task_manager_resource_providers.cc (right):
> 
>
https://codereview.chromium.org/11190016/diff/1/chrome/browser/task_manager/t...
> chrome/browser/task_manager/task_manager_resource_providers.cc:509:
> process_map->Contains(web_contents->GetRenderProcessHost()->GetID());
> I don't think this will work with old style packaged apps or hosted apps.
> Perhaps you need to make this check just for is_platform_app, and also keep
the
> previous check.

This can be closed now I think.

Powered by Google App Engine
This is Rietveld 408576698