Do not add TabContents from packaged apps to the task manager.

chrome/browser/task_manager/task_manager_resource_providers.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_manager/task_manager_resource_providers.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
@@ skipping 296 matching lines @@
     // be LTR format if there is no strong RTL charater in it. Otherwise, if
     // IDS_TASK_MANAGER_TAB_PREFIX is an RTL word, the concatenated result
     // might be wrong. For example, http://mail.yahoo.com, whose title is
     // "Yahoo! Mail: The best web-based Email!", without setting it explicitly
     // as LTR format, the concatenated result will be "!Yahoo! Mail: The best
     // web-based Email :BAT", in which the capital letters "BAT" stands for
     // the Hebrew word for "tab".
     base::i18n::AdjustStringForLocaleDirection(&tab_title);
   }
 
-  // Only classify as an app if the URL is an app and the tab is hosting an
-  // extension process.  (It's possible to be showing the URL from before it
-  // was installed as an app.)
-  ExtensionService* extension_service =
-      tab_contents_->profile()->GetExtensionService();
-  extensions::ProcessMap* process_map = extension_service->process_map();
-  bool is_app = extension_service->IsInstalledApp(url) &&
-      process_map->Contains(contents->GetRenderProcessHost()->GetID());
-
   int message_id = GetMessagePrefixID(
-      is_app,
+      false, // (is_app) Apps do not have TabContents
       HostsExtension(),
       tab_contents_->profile()->IsOffTheRecord(),
       IsPrerendering(),
       is_instant_preview_,
       false);
   return l10n_util::GetStringFUTF16(message_id, tab_title);
 }
 
 string16 TaskManagerTabContentsResource::GetProfileName() const {
   return GetProfileNameFromInfoCache(tab_contents_->profile());
@@ skipping 157 matching lines @@
   std::map<TabContents*, TaskManagerTabContentsResource*>::iterator
       iter = resources_.find(tab_contents);
   DCHECK(iter != resources_.end());
   if (iter != resources_.end())
     iter->second->InstantCommitted();
 }
 
 void TaskManagerTabContentsResourceProvider::Observe(int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
-  TabContents* tab_contents;
-  tab_contents = TabContents::FromWebContents(
-      content::Source<WebContents>(source).ptr());
+  WebContents* web_contents = content::Source<WebContents>(source).ptr();
+  TabContents* tab_contents = TabContents::FromWebContents(web_contents);
   // A background page does not have a TabContents.
   if (!tab_contents)
     return;
+
+  // Only classify as an app if the URL is an app and the tab is hosting an
+  // extension process.  (It's possible to be showing the URL from before it
+  // was installed as an app.)
+  ExtensionService* extension_service =
+      tab_contents->profile()->GetExtensionService();
+  extensions::ProcessMap* process_map = extension_service->process_map();
+  bool is_app = extension_service->IsInstalledApp(web_contents->GetURL()) &&
+      process_map->Contains(web_contents->GetRenderProcessHost()->GetID());

[benwells, 2012/10/17 05:59:49]

I don't think this will work with old style packaged apps or hosted apps.
Perhaps you need to make this check just for is_platform_app, and also keep the
previous check.

+  if (is_app)
+    return;
+
   switch (type) {
     case content::NOTIFICATION_WEB_CONTENTS_CONNECTED:
       Add(tab_contents);
       break;
     case content::NOTIFICATION_WEB_CONTENTS_SWAPPED:
       Remove(tab_contents);
       Add(tab_contents);
       break;
     case content::NOTIFICATION_WEB_CONTENTS_DISCONNECTED:
       Remove(tab_contents);
@@ skipping 1162 matching lines @@
 
   return &resource_;
 }
 
 void TaskManagerBrowserProcessResourceProvider::StartUpdating() {
   task_manager_->AddResource(&resource_);
 }
 
 void TaskManagerBrowserProcessResourceProvider::StopUpdating() {
 }