Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 1118943005: [chrome/browser/chromeos/extensions] Deprecation of loop proxy usage with TTRH (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/chromeos/extensions module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/686f1bbfc1c12432a07d584180d5320a3f096b86 Cr-Commit-Position: refs/heads/master@{#328700}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed Review nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -18 lines) Patch
M chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 3 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_browser_handler_api_test.cc View 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-05 06:43:45 UTC) #2
bshe
Removing myself as reviewer as I am not familiar with file manager related work. Anyone ...
5 years, 7 months ago (2015-05-05 13:24:04 UTC) #3
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-05 14:39:27 UTC) #6
benwells
On 2015/05/05 14:39:27, Pranay wrote: > PTAL > > Thanks Can you run the try ...
5 years, 7 months ago (2015-05-05 20:35:51 UTC) #7
Pranay
Hi Benwell, Not as of now but I have requested access for the same.
5 years, 7 months ago (2015-05-06 02:46:02 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118943005/1
5 years, 7 months ago (2015-05-06 03:16:32 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 03:49:47 UTC) #12
benwells
lgtm with the nit fixed. https://codereview.chromium.org/1118943005/diff/1/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc File chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc (right): https://codereview.chromium.org/1118943005/diff/1/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc#newcode15 chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc:15: #include "base/single_thread_task_runner.h" Nit: this ...
5 years, 7 months ago (2015-05-07 00:05:26 UTC) #13
Pranay
Fixed nit https://codereview.chromium.org/1118943005/diff/1/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc File chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc (right): https://codereview.chromium.org/1118943005/diff/1/chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc#newcode15 chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc:15: #include "base/single_thread_task_runner.h" On 2015/05/07 00:05:26, benwells wrote: ...
5 years, 7 months ago (2015-05-07 03:16:50 UTC) #14
Pranay
Thanks for the review :) Pranay
5 years, 7 months ago (2015-05-07 03:17:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118943005/20001
5 years, 7 months ago (2015-05-07 03:18:28 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-07 03:52:22 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 03:53:15 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/686f1bbfc1c12432a07d584180d5320a3f096b86
Cr-Commit-Position: refs/heads/master@{#328700}

Powered by Google App Engine
This is Rietveld 408576698