chrome/browser/chromeos/extensions/echo_private_apitest.cc - Issue 1118943005: [chrome/browser/chromeos/extensions] Deprecation of loop proxy usage with TTRH

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/echo_private_apitest.cc

Issue 1118943005: [chrome/browser/chromeos/extensions] Deprecation of loop proxy usage with TTRH (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Review nit Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/device_local_account_external_policy_loader_unittest.cc ('k') | chrome/browser/chromeos/extensions/file_manager/event_router.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/echo_private_apitest.cc

diff --git a/chrome/browser/chromeos/extensions/echo_private_apitest.cc b/chrome/browser/chromeos/extensions/echo_private_apitest.cc

index 025762c469d81338e0e65cd6c4e0d3a18a416fb8..ceeae51210201a12e530f57083ad230c19d21663 100644

--- a/chrome/browser/chromeos/extensions/echo_private_apitest.cc

+++ b/chrome/browser/chromeos/extensions/echo_private_apitest.cc

@@ -6,7 +6,7 @@

#include "base/bind.h"

#include "base/command_line.h"

-#include "base/message_loop/message_loop_proxy.h"

+#include "base/thread_task_runner_handle.h"

#include "chrome/browser/chromeos/settings/cros_settings.h"

#include "chrome/browser/chromeos/ui/echo_dialog_view.h"

#include "chrome/browser/extensions/extension_apitest.h"

@@ -81,12 +81,12 @@ class ExtensionEchoPrivateApiTest : public ExtensionApiTest {

// The dialog should stay around until AcceptWindow or CancelWindow is

// called, so base::Unretained is safe.

if (dialog_action == DIALOG_TEST_ACTION_ACCEPT) {

- base::MessageLoopProxy::current()->PostTask(

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(base::IgnoreResult(&chromeos::EchoDialogView::Accept),

base::Unretained(dialog)));

} else if (dialog_action == DIALOG_TEST_ACTION_CANCEL) {

- base::MessageLoopProxy::current()->PostTask(

+ base::ThreadTaskRunnerHandle::Get()->PostTask(

FROM_HERE,

base::Bind(base::IgnoreResult(&chromeos::EchoDialogView::Cancel),

base::Unretained(dialog)));