Don't replicate timeout calculation for browser tests. They do their own timing

tools/testing/dart/test_runner.dart

Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart	(revision 13986)
+++ tools/testing/dart/test_runner.dart	(working copy)
@@ -610,8 +610,11 @@
     process = null;
     int totalSteps = testCase.commands.length;
     String suffix =' (step $currentStep of $totalSteps)';
-    if (timedOut) {
-      // Test timed out before it could complete.
+    if (timedOut &&
+        !(testCase.usesWebDriver && !testCase.configuration['noBatch'])) {

[Jennifer Messerly, 2012/10/23 22:50:19]

might want to add a property for:

    testCase.usesWebDriver && !testCase.configuration['noBatch']

perhaps "testCase.usesBatchRunner"?

[Emily Fortuna, 2012/10/23 23:11:25]

But the dartc tests also "usesBatchRunner"...

[Mads Ager (google), 2012/10/24 05:56:14]

I don't understand why this should change. If we are at the last step which is
running in the browser, the timer should have been cancelled and we should not
get the timedOut case here. If we get the timedOut case here we have not started
the browser part yet and one of the steps before starting the browser timed out
and the test itself times out.

Do the browser test cases have separate test output implementations that
interpret the timedout information and exit code differently? Does it not notice
that the test is timing out if the exit code is 0?

[Mads Ager (google), 2012/10/24 12:03:47]

Something is completely off here. I don't see how usesWebDriver can ever be
true? It is false by default in testCase. BrowserTestCase does not pass in a
usesWebDriver argument, so for all browser test cases it is false too. For other
test cases, we create the test cases passing in a function instead of a
boolean?!?

Emily, could you have a look at this. I think what has been added here makes no
difference at all because the usesWebDriver 'bool' is never true.

+      // Non-webdriver test timed out before it could complete. Webdriver tests
+      // run their own timeouts by timing from the launch of the browser (which
+      // could be delayed).
       testComplete(0, true);
     } else if (currentStep == totalSteps) {
       // Done with all test commands.