tools/testing/dart/test_options.dart - Issue 11189150: Don't replicate timeout calculation for browser tests. They do their own timing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_options.dart

Issue 11189150: Don't replicate timeout calculation for browser tests. They do their own timing (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_options.dart

===================================================================

--- tools/testing/dart/test_options.dart (revision 13986)

+++ tools/testing/dart/test_options.dart (working copy)

@@ -563,9 +563,7 @@

if (Contains(configuration['runtime'],

const ['ie9', 'ie10', 'ff', 'chrome', 'safari',

'opera'])) {

- // TODO(ahe): Restore the timeout to 8 times the original timeout

- // when dart2js compile-time performance has improved.

- timeout *= 12; // Allow additional time for browser testing to run.

Emily Fortuna 2012/10/23 22:23:48 This file is just a revert of a previous debugging

+ timeout *= 8; // Allow additional time for browser testing to run.

}

break;

default:

« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | tools/testing/dart/test_runner.dart » ('J')