Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: tools/testing/dart/test_options.dart

Issue 11189150: Don't replicate timeout calculation for browser tests. They do their own timing (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | tools/testing/dart/test_runner.dart » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_options_parser"); 5 #library("test_options_parser");
6 6
7 #import("dart:io"); 7 #import("dart:io");
8 #import("dart:math"); 8 #import("dart:math");
9 #import("drt_updater.dart"); 9 #import("drt_updater.dart");
10 #import("test_suite.dart"); 10 #import("test_suite.dart");
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 } 556 }
557 if (configuration['host_checked']) { 557 if (configuration['host_checked']) {
558 timeout *= 16; 558 timeout *= 16;
559 } 559 }
560 if (configuration['checked']) { 560 if (configuration['checked']) {
561 timeout *= 2; 561 timeout *= 2;
562 } 562 }
563 if (Contains(configuration['runtime'], 563 if (Contains(configuration['runtime'],
564 const ['ie9', 'ie10', 'ff', 'chrome', 'safari', 564 const ['ie9', 'ie10', 'ff', 'chrome', 'safari',
565 'opera'])) { 565 'opera'])) {
566 // TODO(ahe): Restore the timeout to 8 times the original timeout 566 timeout *= 8; // Allow additional time for browser testing to run.
567 // when dart2js compile-time performance has improved.
568 timeout *= 12; // Allow additional time for browser testing to run.
Emily Fortuna 2012/10/23 22:23:48 This file is just a revert of a previous debugging
569 } 567 }
570 break; 568 break;
571 default: 569 default:
572 if (configuration['mode'] == 'debug') { 570 if (configuration['mode'] == 'debug') {
573 timeout *= 2; 571 timeout *= 2;
574 } 572 }
575 if (Contains(configuration['runtime'], const ['drt', 'dartium'])) { 573 if (Contains(configuration['runtime'], const ['drt', 'dartium'])) {
576 timeout *= 4; // Allow additional time for browser testing to run. 574 timeout *= 4; // Allow additional time for browser testing to run.
577 } 575 }
578 break; 576 break;
(...skipping 72 matching lines...) Expand 10 before | Expand all | Expand 10 after
651 return option; 649 return option;
652 } 650 }
653 } 651 }
654 print('Unknown test option $name'); 652 print('Unknown test option $name');
655 exit(1); 653 exit(1);
656 } 654 }
657 655
658 656
659 List<_TestOptionSpecification> _options; 657 List<_TestOptionSpecification> _options;
660 } 658 }
OLDNEW
« no previous file with comments | « no previous file | tools/testing/dart/test_runner.dart » ('j') | tools/testing/dart/test_runner.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698