mojo/public/cpp/bindings/interface_request.h - Issue 1118843003: Remove some InterfacePtr<> methods which directly deal with message pipe handles.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/cpp/bindings/interface_request.h

Issue 1118843003: Remove some InterfacePtr<> methods which directly deal with message pipe handles. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « mojo/public/cpp/bindings/interface_ptr.h ('k') | mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc » ('j') | sky/engine/core/html/HTMLIFrameElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/cpp/bindings/interface_request.h

diff --git a/mojo/public/cpp/bindings/interface_request.h b/mojo/public/cpp/bindings/interface_request.h

index 488b679d817db1ff3d9d1ae06daa5a82f708a32d..c139306e2c8d671871c039d3960e5178bc7e546d 100644

--- a/mojo/public/cpp/bindings/interface_request.h

+++ b/mojo/public/cpp/bindings/interface_request.h

@@ -109,7 +109,7 @@ InterfaceRequest<Interface> MakeRequest(ScopedMessagePipeHandle handle) {

template <typename Interface>

InterfaceRequest<Interface> GetProxy(InterfacePtr<Interface>* ptr) {

MessagePipe pipe;

- ptr->Bind(pipe.handle0.Pass());

+ ptr->Bind(InterfacePtrInfo<Interface>(pipe.handle0.Pass(), 0u));

return MakeRequest<Interface>(pipe.handle1.Pass());

}