Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Unified Diff: sky/engine/core/html/HTMLIFrameElement.cpp

Issue 1118843003: Remove some InterfacePtr<> methods which directly deal with message pipe handles. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « shell/shell_test_base.h ('k') | sky/viewer/document_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/html/HTMLIFrameElement.cpp
diff --git a/sky/engine/core/html/HTMLIFrameElement.cpp b/sky/engine/core/html/HTMLIFrameElement.cpp
index edbbc748a1b09dd3326a4d56259dab3c4bd63897..b76ec4bf66ccc44f48033ce24f1ebeff9d5807e6 100644
--- a/sky/engine/core/html/HTMLIFrameElement.cpp
+++ b/sky/engine/core/html/HTMLIFrameElement.cpp
@@ -85,8 +85,9 @@ void HTMLIFrameElement::embedViewManagerClient(RefPtr<DartValue> client)
if (!m_contentView)
return;
- m_contentView->Embed(mojo::MakeProxy<mojo::ViewManagerClient>(
- DartConverter<mojo::ScopedMessagePipeHandle>::FromDart(client->dart_value())));
+ m_contentView->Embed(mojo::MakeProxy(
+ mojo::InterfacePtrInfo<mojo::ViewManagerClient>(
jamesr 2015/04/30 23:00:46 this could probably use a temporary variable or fe
yzshen1 2015/04/30 23:21:56 Done.
+ DartConverter<mojo::ScopedMessagePipeHandle>::FromDart(client->dart_value()), 0u)));
}
void HTMLIFrameElement::navigateView()
@@ -105,7 +106,7 @@ void HTMLIFrameElement::navigateView()
m_contentView->Embed(mojo::String::From(url.string().utf8().data()),
mojo::GetProxy(&m_services),
- mojo::MakeProxy<mojo::ServiceProvider>(exposedServicesPipe.handle1.Pass()));
+ mojo::MakeProxy(mojo::InterfacePtrInfo<mojo::ServiceProvider>(exposedServicesPipe.handle1.Pass(), 0u)));
}
}
« no previous file with comments | « shell/shell_test_base.h ('k') | sky/viewer/document_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698