Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1118693003: add heuristic to pour small pictures into recordings, rather than ref'ing (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
Reviewers:
f(malita), mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add heuristic to pour small pictures into recordings, rather than ref'ing BUG=skia: Committed: https://skia.googlesource.com/skia/+/1c2c441fede0ae9573afc098017011e3439624a9

Patch Set 1 #

Patch Set 2 : move check into SkCanvas non-virtual #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -33 lines) Patch
M include/core/SkCanvas.h View 1 1 chunk +3 lines, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 2 chunks +16 lines, -9 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/RecorderTest.cpp View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
reed1
5 years, 7 months ago (2015-04-30 19:44:55 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118693003/1
5 years, 7 months ago (2015-04-30 19:45:16 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-30 19:48:49 UTC) #6
reed1
ptal
5 years, 7 months ago (2015-04-30 20:01:41 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118693003/20001
5 years, 7 months ago (2015-04-30 20:01:55 UTC) #9
f(malita)
Wow! Such shrinkage! Much LGTM (quick SP http://en.wikipedia.org/wiki/Wikipedia test - drawPicture: ~10000 -> ~1400, skp ...
5 years, 7 months ago (2015-04-30 20:03:08 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-30 20:05:43 UTC) #12
mtklein
lgtm
5 years, 7 months ago (2015-04-30 20:08:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118693003/20001
5 years, 7 months ago (2015-04-30 20:09:14 UTC) #15
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 20:09:31 UTC) #16
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1c2c441fede0ae9573afc098017011e3439624a9

Powered by Google App Engine
This is Rietveld 408576698