tests/PictureTest.cpp - Issue 1118693003: add heuristic to pour small pictures into recordings, rather than ref'ing

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PictureTest.cpp

Issue 1118693003: add heuristic to pour small pictures into recordings, rather than ref'ing (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: move check into SkCanvas non-virtual Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/PictureTest.cpp

diff --git a/tests/PictureTest.cpp b/tests/PictureTest.cpp

index 4fe08379dd0545e8648f660fb514d28d8098f525..16d98b324517d670339181410e8892deb53ea898 100644

--- a/tests/PictureTest.cpp

+++ b/tests/PictureTest.cpp

@@ -1127,7 +1127,7 @@ static void test_bytes_used(skiatest::Reporter* reporter) {

r2.getRecordingCanvas()->drawPicture(empty.get());

SkAutoTUnref<SkPicture> nested(r2.endRecording());

- REPORTER_ASSERT(reporter, SkPictureUtils::ApproximateBytesUsed(nested.get()) >

+ REPORTER_ASSERT(reporter, SkPictureUtils::ApproximateBytesUsed(nested.get()) >=

SkPictureUtils::ApproximateBytesUsed(empty.get()));

}

« no previous file with comments | « src/core/SkCanvas.cpp ('k') | tests/RecorderTest.cpp » ('j') | no next file with comments »