Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: Source/core/html/track/TextTrackKindUserPreference.h

Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed comments from fs Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/track/TextTrackKindUserPreference.h
diff --git a/Source/core/html/track/TextTrackKindUserPreference.h b/Source/core/html/track/TextTrackKindUserPreference.h
new file mode 100644
index 0000000000000000000000000000000000000000..871c7ec1b46f97febe32a967fb47ac95f1b6b287
--- /dev/null
+++ b/Source/core/html/track/TextTrackKindUserPreference.h
@@ -0,0 +1,22 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef TextTrackKindUserPreference_h
+#define TextTrackKindUserPreference_h
+
+namespace blink {
+
+// Defines user preference for text track kind.
+enum class TextTrackKindUserPreference {
+ // Display only tracks marked as default
fs 2015/06/24 08:59:07 Nit: End with full stop ('.').
srivats 2015/07/02 01:41:21 Done.
+ Default,
+ // Display caption tracks if available and if not display subtitles in preferred language
fs 2015/06/24 08:59:07 Ditto.
srivats 2015/07/02 01:41:21 Done.
+ Captions,
+ // Display subtitle tracks if available
fs 2015/06/24 08:59:07 Ditto.
philipj_slow 2015/06/24 09:54:20 This should also fall back to captions in the pref
srivats 2015/07/02 01:41:21 Since we didn't really have a case for subtitles,
srivats 2015/07/02 01:41:21 Done.
philipj_slow 2015/07/09 15:20:49 The documentation is the same in the most recent C
srivats 2015/07/09 21:25:37 Sorry I missed updating this earlier.
+ Subtitles
+};
+
+} // namespace blink
+
+#endif // TextTrackKindUserPreference_h

Powered by Google App Engine
This is Rietveld 408576698