Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Side by Side Diff: Source/core/html/track/TextTrackKindUserPreference.h

Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressed comments from fs Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef TextTrackKindUserPreference_h
6 #define TextTrackKindUserPreference_h
7
8 namespace blink {
9
10 // Defines user preference for text track kind.
11 enum class TextTrackKindUserPreference {
12 // Display only tracks marked as default
fs 2015/06/24 08:59:07 Nit: End with full stop ('.').
srivats 2015/07/02 01:41:21 Done.
13 Default,
14 // Display caption tracks if available and if not display subtitles in prefe rred language
fs 2015/06/24 08:59:07 Ditto.
srivats 2015/07/02 01:41:21 Done.
15 Captions,
16 // Display subtitle tracks if available
fs 2015/06/24 08:59:07 Ditto.
philipj_slow 2015/06/24 09:54:20 This should also fall back to captions in the pref
srivats 2015/07/02 01:41:21 Since we didn't really have a case for subtitles,
srivats 2015/07/02 01:41:21 Done.
philipj_slow 2015/07/09 15:20:49 The documentation is the same in the most recent C
srivats 2015/07/09 21:25:37 Sorry I missed updating this earlier.
17 Subtitles
18 };
19
20 } // namespace blink
21
22 #endif // TextTrackKindUserPreference_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698