Source/core/frame/Settings.in - Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/frame/Settings.in

Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments from fs Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/frame/Settings.in

diff --git a/Source/core/frame/Settings.in b/Source/core/frame/Settings.in

index d22d096668061b60e6557b4a43bf34cf950c07f6..5616cfab9a52bf426d5b36cde2e90d21d51ba6e1 100644

--- a/Source/core/frame/Settings.in

+++ b/Source/core/frame/Settings.in

@@ -329,6 +329,10 @@ logPreload initial=false

# Android, and dynamically set by the inspector for mobile emulation.

useMobileViewportStyle initial=false, invalidate=ViewportRule

+# AutomaticTrackSelection is performed based on user preference for track kind specified

fs 2015/06/24 08:59:07 Nit: Should probably be "Automatic track selection

srivats 2015/07/02 01:41:20 Done.

+# by this setting.

+textTrackKindUserPreference type=TextTrackKindUserPreference, initial=TextTrackKindUserPreference::Default, invalidate=TextTrackKindUserPreference

# User style overrides for captions and subtitles

textTrackBackgroundColor type=String

textTrackFontFamily type=String

« Source/core/frame/Settings.h ('K') | « Source/core/frame/Settings.h ('k') | Source/core/frame/SettingsDelegate.h » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')