Source/core/frame/Settings.in - Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink

Side by Side Diff: Source/core/frame/Settings.in

Issue 1118613002: Hook up Android closed captions 'enabled' setting to Blink (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressed comments from fs Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Defines properties which are available on the Settings object.	1 # Defines properties which are available on the Settings object.

2 #	2 #

3 # Please think carefully before adding a new Setting. Some questions to	3 # Please think carefully before adding a new Setting. Some questions to

4 # consider are:	4 # consider are:

5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things	5 # - Should this be a RuntimeEnabledFeature instead? Settings are for things

6 # which we support either values of at runtime. Features are set at renderer	6 # which we support either values of at runtime. Features are set at renderer

7 # process startup and are never changed. Features also tend to be set to a	7 # process startup and are never changed. Features also tend to be set to a

8 # value based on the platform or the stability of the code in question, where	8 # value based on the platform or the stability of the code in question, where

9 # as settings both codepaths need to be stable.	9 # as settings both codepaths need to be stable.

10 # - How will you ensure test coverage of all relevant values of your setting?	10 # - How will you ensure test coverage of all relevant values of your setting?

(...skipping 311 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
322 disableReadingFromCanvas initial=false	322 disableReadingFromCanvas initial=false

323 strictMixedContentChecking initial=false	323 strictMixedContentChecking initial=false

324 strictPowerfulFeatureRestrictions initial=false	324 strictPowerfulFeatureRestrictions initial=false

325 logDnsPrefetchAndPreconnect initial=false	325 logDnsPrefetchAndPreconnect initial=false

326 logPreload initial=false	326 logPreload initial=false

327	327

328 # If true, the UA styles will include viewportAndroid.css. It is used for	328 # If true, the UA styles will include viewportAndroid.css. It is used for

329 # Android, and dynamically set by the inspector for mobile emulation.	329 # Android, and dynamically set by the inspector for mobile emulation.

330 useMobileViewportStyle initial=false, invalidate=ViewportRule	330 useMobileViewportStyle initial=false, invalidate=ViewportRule

331	331

	332 # AutomaticTrackSelection is performed based on user preference for track kind s pecified
	fs 2015/06/24 08:59:07 Nit: Should probably be "Automatic track selection Nit: Should probably be "Automatic track selection" at the beginning here. srivats 2015/07/02 01:41:20 Done. Show quoted text On 2015/06/24 08:59:07, fs wrote: > Nit: Should probably be "Automatic track selection" at the beginning here. Done.
	333 # by this setting.

	334 textTrackKindUserPreference type=TextTrackKindUserPreference, initial=TextTrackK indUserPreference::Default, invalidate=TextTrackKindUserPreference

	335

332 # User style overrides for captions and subtitles	336 # User style overrides for captions and subtitles

333 textTrackBackgroundColor type=String	337 textTrackBackgroundColor type=String

334 textTrackFontFamily type=String	338 textTrackFontFamily type=String

335 textTrackFontStyle type=String	339 textTrackFontStyle type=String

336 textTrackFontVariant type=String	340 textTrackFontVariant type=String

337 textTrackTextColor type=String	341 textTrackTextColor type=String

338 textTrackTextShadow type=String	342 textTrackTextShadow type=String

339 textTrackTextSize type=String	343 textTrackTextSize type=String

340	344

341 lowPriorityIframes initial=false	345 lowPriorityIframes initial=false

OLD	NEW

« Source/core/frame/Settings.h ('K') | « Source/core/frame/Settings.h ('k') | Source/core/frame/SettingsDelegate.h » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')