Issue 111853003: Revert of Shut up the CoreText performance note.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 111853003: Revert of Shut up the CoreText performance note. (Closed)

Created:
7 years ago by mtklein

Modified:
7 years ago

Reviewers:
bungeman-skia, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Revert of https://codereview.chromium.org/109033002/ Reason for revert: I suspect this is causing GM to crash on Mac. TBR=bungeman@google.com,reed@google.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=12603

Patch Set 1 #

Created: 7 years ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -7 lines)			Patch
	M	src/ports/SkFontHost_mac.cpp	View		1 chunk	+1 line, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/111853003/1

7 years ago (2013-12-10 17:08:46 UTC) #2

mtklein

7 years ago (2013-12-10 17:58:49 UTC) #4

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/102243009/ by mtklein@google.com.

The reason for reverting is: Was not the culprit..

Expand Messages | Collapse Messages