Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Issue 1118483002: [chrome/browser/policy] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
CC:
chromium-reviews, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/policy module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/6825391d97429c8bcddf69aac7392d75ce6c481c Cr-Commit-Position: refs/heads/master@{#327692}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Fixed Review Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -18 lines) Patch
M chrome/browser/policy/cloud/test_request_interceptor.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_invalidator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 1 3 chunks +5 lines, -6 lines 0 comments Download
M chrome/browser/policy/url_blacklist_manager_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-04-29 12:49:00 UTC) #2
pneubeck (no reviews)
lgtm with minor changes https://codereview.chromium.org/1118483002/diff/1/chrome/browser/policy/cloud/test_request_interceptor.cc File chrome/browser/policy/cloud/test_request_interceptor.cc (right): https://codereview.chromium.org/1118483002/diff/1/chrome/browser/policy/cloud/test_request_interceptor.cc#newcode290 chrome/browser/policy/cloud/test_request_interceptor.cc:290: base::Bind(base::IgnoreResult(&base::MessageLoopProxy::PostTask), this reads very inconsistent. ...
5 years, 7 months ago (2015-04-30 08:00:08 UTC) #3
Pranay
Hi Pneubeck, Thanks for the review. Have updated the changes in new patch set :)
5 years, 7 months ago (2015-04-30 09:34:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1118483002/20001
5 years, 7 months ago (2015-04-30 09:35:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-04-30 10:38:19 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6825391d97429c8bcddf69aac7392d75ce6c481c Cr-Commit-Position: refs/heads/master@{#327692}
5 years, 7 months ago (2015-04-30 10:39:04 UTC) #9
Pranay
5 years, 7 months ago (2015-05-04 03:26:59 UTC) #10
Message was sent while issue was closed.
Done

https://codereview.chromium.org/1118483002/diff/1/chrome/browser/policy/cloud...
File chrome/browser/policy/cloud/test_request_interceptor.cc (right):

https://codereview.chromium.org/1118483002/diff/1/chrome/browser/policy/cloud...
chrome/browser/policy/cloud/test_request_interceptor.cc:290:
base::Bind(base::IgnoreResult(&base::MessageLoopProxy::PostTask),
On 2015/04/30 08:00:08, pneubeck wrote:
> this reads very inconsistent.
> Shouldn't this be changed to
>  ...IgnoreResult(&base::TaskRunner::PostTask)...
> ?

Done.

https://codereview.chromium.org/1118483002/diff/1/chrome/browser/policy/cloud...
chrome/browser/policy/cloud/test_request_interceptor.cc:335:
base::IgnoreResult(&base::MessageLoopProxy::PostTask),
On 2015/04/30 08:00:08, pneubeck wrote:
> ditto.
> 
> now you should be able to remove the include
> "base/message_loop/message_loop_proxy.h"
> as well.

Done.

https://codereview.chromium.org/1118483002/diff/1/chrome/browser/policy/cloud...
File chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc (right):

https://codereview.chromium.org/1118483002/diff/1/chrome/browser/policy/cloud...
chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc:6: #include
"base/message_loop/message_loop.h"
On 2015/04/30 08:00:08, pneubeck wrote:
> also not required anymore? (I can't find any reference to MessageLoop)

Done.

Powered by Google App Engine
This is Rietveld 408576698