chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc - Issue 1118483002: [chrome/browser/policy] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

Issue 1118483002: [chrome/browser/policy] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Review Comments Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/policy/cloud/user_cloud_policy_manager_factory.cc ('k') | chrome/browser/policy/url_blacklist_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

diff --git a/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc b/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

index 0cd839f0ce8675677698b1389c58b06bb7c9c054..047dcd9698ff599f611ee442d0aa68071a1dc477 100644

--- a/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

+++ b/chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc

@@ -3,10 +3,9 @@

// found in the LICENSE file.

#include "base/files/file_path.h"

-#include "base/message_loop/message_loop.h"

-#include "base/message_loop/message_loop_proxy.h"

#include "base/prefs/pref_service.h"

#include "base/run_loop.h"

+#include "base/thread_task_runner_handle.h"

#include "base/time/time.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/chrome_notification_types.h"

@@ -110,9 +109,9 @@ UserCloudPolicyManager* BuildCloudPolicyManager(

scoped_ptr<UserCloudPolicyStore>(store),

base::FilePath(),

scoped_ptr<CloudExternalDataManager>(),

- base::MessageLoopProxy::current(),

- base::MessageLoopProxy::current());

+ base::ThreadTaskRunnerHandle::Get(),

+ base::ThreadTaskRunnerHandle::Get());

}

class UserPolicySigninServiceTest : public testing::Test {

@@ -158,7 +157,7 @@ class UserPolicySigninServiceTest : public testing::Test {

local_state_.reset(new TestingPrefServiceSimple);

chrome::RegisterLocalState(local_state_->registry());

system_request_context_getter_ = new net::TestURLRequestContextGetter(

- base::MessageLoopProxy::current());

+ base::ThreadTaskRunnerHandle::Get());

TestingBrowserProcess::GetGlobal()->SetSystemRequestContext(

system_request_context_getter_.get());

TestingBrowserProcess::GetGlobal()->SetLocalState(local_state_.get());