Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: tools/run-tests.py

Issue 11184039: Use tools/run-tests.py for "check" targets in the top-level Makefile. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: fixed run-tests.py return value Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Makefile ('k') | tools/testrunner/local/execution.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/run-tests.py
diff --git a/tools/run-tests.py b/tools/run-tests.py
index cab93fb6079fc256b278fcc573f0b0cdb18647b2..5d90d1947e98efc831292d0fd251a2283d52d2a4 100755
--- a/tools/run-tests.py
+++ b/tools/run-tests.py
@@ -174,12 +174,6 @@ def ProcessOptions(options):
options.shell_dir = os.path.dirname(options.shell)
if options.stress_only:
VARIANT_FLAGS = [["--stress-opt", "--always-opt"]]
- # Simulators are slow, therefore allow a longer default timeout.
- if options.timeout == -1:
- if options.arch == "arm" or options.arch == "mipsel":
- options.timeout = 2 * TIMEOUT_DEFAULT;
- else:
- options.timeout = TIMEOUT_DEFAULT;
if options.valgrind:
run_valgrind = os.path.join("tools", "run-valgrind.py")
# This is OK for distributed running, so we don't need to set no_network.
@@ -264,10 +258,18 @@ def Execute(arch, mode, args, options, suites, workspace):
# Populate context object.
mode_flags = MODE_FLAGS[mode]
+ timeout = options.timeout
+ if timeout == -1:
+ # Simulators are slow, therefore allow a longer default timeout.
+ if arch in ["android", "arm", "mipsel"]:
+ timeout = 2 * TIMEOUT_DEFAULT;
+ else:
+ timeout = TIMEOUT_DEFAULT;
+
options.timeout *= TIMEOUT_SCALEFACTOR[mode]
ctx = context.Context(arch, mode, shell_dir,
mode_flags, options.verbose,
- options.timeout, options.isolates,
+ timeout, options.isolates,
options.command_prefix,
options.extra_flags)
« no previous file with comments | « Makefile ('k') | tools/testrunner/local/execution.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698