tools/testrunner/local/execution.py - Issue 11184039: Use tools/run-tests.py for "check" targets in the top-level Makefile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testrunner/local/execution.py

Issue 11184039: Use tools/run-tests.py for "check" targets in the top-level Makefile. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fixed run-tests.py return value Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testrunner/local/execution.py

diff --git a/tools/testrunner/local/execution.py b/tools/testrunner/local/execution.py

index 25df0436256cd5b46609c7ee6335254f342d911d..0adf9c90718744d395b538dcb647f513e9891abb 100644

--- a/tools/testrunner/local/execution.py

+++ b/tools/testrunner/local/execution.py

@@ -90,7 +90,9 @@ class Runner(object):

self.indicator.Starting()

self._RunInternal(jobs)

self.indicator.Done()

- return not self.failed

+ if self.failed:

+ return 1

+ return 0

def _RunInternal(self, jobs):

pool = multiprocessing.Pool(processes=jobs)

@@ -147,6 +149,7 @@ class Runner(object):

except KeyboardInterrupt:

pool.terminate()

pool.join()

+ raise

except Exception, e:

print("Exception: %s" % e)

pool.terminate()

« no previous file with comments | « tools/run-tests.py ('k') | tools/testrunner/local/progress.py » ('j') | no next file with comments »