Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 11184039: Use tools/run-tests.py for "check" targets in the top-level Makefile. (Closed)

Created:
8 years, 2 months ago by Jakob Kummerow
Modified:
8 years, 2 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Use tools/run-tests.py for "check" targets in the top-level Makefile. Bonus content: a few minor fixes for run-tests.py Committed: https://code.google.com/p/v8/source/detail?r=12758

Patch Set 1 #

Patch Set 2 : fixed run-tests.py return value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -16 lines) Patch
M Makefile View 3 chunks +8 lines, -8 lines 0 comments Download
M tools/run-tests.py View 2 chunks +9 lines, -7 lines 0 comments Download
M tools/testrunner/local/execution.py View 1 2 chunks +4 lines, -1 line 0 comments Download
M tools/testrunner/local/progress.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
PTAL.
8 years, 2 months ago (2012-10-18 13:44:43 UTC) #1
Yang
8 years, 2 months ago (2012-10-18 14:11:03 UTC) #2
On 2012/10/18 13:44:43, Jakob wrote:
> PTAL.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698