Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1118353005: Subzero: Use a setcc sequence for better icmp lowering. (Closed)

Created:
5 years, 7 months ago by Jim Stichnoth
Modified:
5 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Use a setcc sequence for better icmp lowering. For an example like: %a = icmp eq i32 %b, %c The original icmp lowering sequence for i8/i16/i32 was something like: cmpl b, c movb 1, a je label movb 0, a label: The improved sequence is: cmpl b, c sete a In O2 mode, this doesn't help when successive compare/branch instructions are fused, but it does help when the boolean result needs to be saved and later used. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f48b320c64ccd0ace2b873fd54471e0938c2f0ce

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -18 lines) Patch
M src/IceInstX8632.h View 2 chunks +25 lines, -0 lines 0 comments Download
M src/IceInstX8632.cpp View 2 chunks +32 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/IceTargetLoweringX8632.cpp View 1 chunk +1 line, -5 lines 0 comments Download
M src/assembler_ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler_ia32.cpp View 1 1 chunk +8 lines, -0 lines 0 comments Download
M tests_lit/assembler/x86/sandboxing.ll View 1 1 chunk +5 lines, -4 lines 0 comments Download
M tests_lit/llvm2ice_tests/8bit.pnacl.ll View 1 chunk +1 line, -1 line 0 comments Download
M tests_lit/llvm2ice_tests/branch-opt.ll View 2 chunks +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/nacl-atomic-cmpxchg-optimization.ll View 2 chunks +2 lines, -2 lines 0 comments Download
M tests_lit/llvm2ice_tests/phi.ll View 1 chunk +1 line, -3 lines 0 comments Download
M tests_lit/llvm2ice_tests/simple-loop.ll View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jim Stichnoth
This makes each Spec2k component about 2% smaller, but has little measurable effect on performance.
5 years, 7 months ago (2015-05-01 21:23:18 UTC) #2
jvoung (off chromium)
Cool -- LGTM
5 years, 7 months ago (2015-05-04 16:28:21 UTC) #3
Jim Stichnoth
5 years, 7 months ago (2015-05-04 17:22:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f48b320c64ccd0ace2b873fd54471e0938c2f0ce (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698