Source/core/rendering/svg/SVGTextMetricsBuilder.cpp - Issue 111833006: Avoiding multiple text/string parsing while creating TextRun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

Issue 111833006: Avoiding multiple text/string parsing while creating TextRun (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@FontOptPatch1

Patch Set: Fixing merge issues after LGTM Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

diff --git a/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp b/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

index f8189602b3c50ac22c7f7e76a9e858409f0d9ec9..55dc71f7ab71e0af722c755874900b889f7cfeea 100644

--- a/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

+++ b/Source/core/rendering/svg/SVGTextMetricsBuilder.cpp

@@ -102,7 +102,9 @@ void SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer(RenderSVGInlin

const Font& scaledFont = text->scaledFont();

m_run = SVGTextMetrics::constructTextRun(text, 0, text->textLength());

- m_isComplexText = scaledFont.codePath(m_run) == ComplexPath;

+ CodePath codePath = scaledFont.codePath(m_run);

+ m_isComplexText = codePath == ComplexPath;

+ m_run.setCharacterScanForCodePath(!m_isComplexText);

if (m_isComplexText)

m_simpleWidthIterator.clear();

« no previous file with comments | « Source/core/rendering/InlineTextBox.cpp ('k') | no next file » | no next file with comments »