Source/core/rendering/InlineTextBox.cpp - Issue 111833006: Avoiding multiple text/string parsing while creating TextRun

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/InlineTextBox.cpp

Issue 111833006: Avoiding multiple text/string parsing while creating TextRun (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@FontOptPatch1

Patch Set: Fixing merge issues after LGTM Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/InlineTextBox.cpp

diff --git a/Source/core/rendering/InlineTextBox.cpp b/Source/core/rendering/InlineTextBox.cpp

old mode 100644

new mode 100755

index ecce9cd748cc438841805549c0d4812ac8ecd634..3b878ede8adf9159d764c16d591994287dd65c94

--- a/Source/core/rendering/InlineTextBox.cpp

+++ b/Source/core/rendering/InlineTextBox.cpp

@@ -1521,6 +1521,7 @@ TextRun InlineTextBox::constructTextRun(RenderStyle* style, const Font& font, St

TextRun run(string, textPos(), expansion(), expansionBehavior(), direction(), dirOverride() || style->rtlOrdering() == VisualOrder, !textRenderer->canUseSimpleFontCodePath());

run.setTabSize(!style->collapseWhiteSpace(), style->tabSize());

+ run.setCharacterScanForCodePath(!textRenderer->canUseSimpleFontCodePath());

run.setDistributeJustification(style->textJustify() == TextJustifyDistribute);

if (textRunNeedsRenderingContext(font))

run.setRenderingContext(SVGTextRunRenderingContext::create(textRenderer));

« no previous file with comments | « PerformanceTests/Layout/SimpleTextPathLineLayout.html ('k') | Source/core/rendering/svg/SVGTextMetricsBuilder.cpp » ('j') | no next file with comments »