Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Unified Diff: Source/core/rendering/RenderText.h

Issue 111833006: Avoiding multiple text/string parsing while creating TextRun (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@FontOptPatch1
Patch Set: Fixing review comments for rebasing files Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderText.h
diff --git a/Source/core/rendering/RenderText.h b/Source/core/rendering/RenderText.h
old mode 100644
new mode 100755
index 13af4be1c6bdb366d0380d260046d4b86b862c06..909b293b93648806d29650a225d4142cfbc0d425
--- a/Source/core/rendering/RenderText.h
+++ b/Source/core/rendering/RenderText.h
@@ -24,6 +24,7 @@
#define RenderText_h
#include "core/rendering/RenderObject.h"
+#include "platform/text/TextPath.h"
#include "wtf/Forward.h"
#include "wtf/PassRefPtr.h"
@@ -143,6 +144,7 @@ public:
bool knownToHaveNoOverflowAndNoFallbackFonts() const { return m_knownToHaveNoOverflowAndNoFallbackFonts; }
void removeAndDestroyTextBoxes();
+ CodePath getCodePath() const { return m_textCodePath;}
eseidel 2013/12/27 04:36:45 Blink doesn't prefix simple getters with "get"
eae 2013/12/30 19:29:14 Like Eric said, this should be "CodePath codePath(
h.joshi 2013/12/31 06:07:43 Yes I have fixed this will update code soon with f
PassRefPtr<AbstractInlineTextBox> firstAbstractInlineTextBox();
@@ -163,7 +165,7 @@ protected:
private:
void computePreferredLogicalWidths(float leadWidth, HashSet<const SimpleFontData*>& fallbackFonts, GlyphOverflow&);
- bool computeCanUseSimpleFontCodePath() const;
+ bool computeCanUseSimpleFontCodePath();
// Make length() private so that callers that have a RenderText*
// will use the more efficient textLength() instead, while
@@ -206,6 +208,8 @@ private:
InlineTextBox* m_firstTextBox;
InlineTextBox* m_lastTextBox;
+
+ CodePath m_textCodePath;
};
inline UChar RenderText::uncheckedCharacterAt(unsigned i) const

Powered by Google App Engine
This is Rietveld 408576698