Avoiding multiple text/string parsing while creating TextRun

Source/core/rendering/RenderText.h

 /*
  * (C) 1999 Lars Knoll (knoll@kde.org)
  * (C) 2000 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef RenderText_h
 #define RenderText_h
 
 #include "core/rendering/RenderObject.h"
+#include "platform/text/TextPath.h"
 #include "wtf/Forward.h"
 #include "wtf/PassRefPtr.h"
 
 namespace WebCore {
 
 class AbstractInlineTextBox;
 class InlineTextBox;
 
 class RenderText : public RenderObject {
 public:
@@ skipping 99 matching lines @@
     InlineTextBox* findNextInlineTextBox(int offset, int& pos) const;
 
     void checkConsistency() const;
 
     bool isAllCollapsibleWhitespace() const;
 
     bool canUseSimpleFontCodePath() const { return m_canUseSimpleFontCodePath; }
     bool knownToHaveNoOverflowAndNoFallbackFonts() const { return m_knownToHaveNoOverflowAndNoFallbackFonts; }
 
     void removeAndDestroyTextBoxes();
+    CodePath getCodePath() const { return m_textCodePath;}

[eseidel, 2013/12/27 04:36:45]

Blink doesn't prefix simple getters with "get"

[eae, 2013/12/30 19:29:14]

Like Eric said, this should be "CodePath codePath() const {"

[h.joshi, 2013/12/31 06:07:43]

Yes I have fixed this will update code soon with fix.

 
     PassRefPtr<AbstractInlineTextBox> firstAbstractInlineTextBox();
 
 protected:
     virtual void computePreferredLogicalWidths(float leadWidth);
     virtual void willBeDestroyed();
 
     virtual void styleWillChange(StyleDifference, const RenderStyle*) OVERRIDE FINAL { }
     virtual void styleDidChange(StyleDifference, const RenderStyle* oldStyle);
 
     virtual void setTextInternal(PassRefPtr<StringImpl>);
     virtual UChar previousCharacter() const;
 
     virtual void addLayerHitTestRects(LayerHitTestRects&, const RenderLayer* currentLayer, const LayoutPoint& layerOffset, const LayoutRect& containerRect) const OVERRIDE;
 
     virtual InlineTextBox* createTextBox(); // Subclassed by SVG.
 
 private:
     void computePreferredLogicalWidths(float leadWidth, HashSet<const SimpleFontData*>& fallbackFonts, GlyphOverflow&);
 
-    bool computeCanUseSimpleFontCodePath() const;
+    bool computeCanUseSimpleFontCodePath();
 
     // Make length() private so that callers that have a RenderText*
     // will use the more efficient textLength() instead, while
     // callers with a RenderObject* can continue to use length().
     virtual unsigned length() const OVERRIDE FINAL { return textLength(); }
 
     virtual void paint(PaintInfo&, const LayoutPoint&) OVERRIDE FINAL { ASSERT_NOT_REACHED(); }
     virtual void layout() OVERRIDE FINAL { ASSERT_NOT_REACHED(); }
     virtual bool nodeAtPoint(const HitTestRequest&, HitTestResult&, const HitTestLocation&, const LayoutPoint&, HitTestAction) OVERRIDE FINAL { ASSERT_NOT_REACHED(); return false; }
 
@@ skipping 22 matching lines @@
 
     float m_minWidth;
     float m_maxWidth;
     float m_firstLineMinWidth;
     float m_lastLineLineMinWidth;
 
     String m_text;
 
     InlineTextBox* m_firstTextBox;
     InlineTextBox* m_lastTextBox;
+
+    CodePath m_textCodePath;
 };
 
 inline UChar RenderText::uncheckedCharacterAt(unsigned i) const
 {
     ASSERT_WITH_SECURITY_IMPLICATION(i < textLength());
     return is8Bit() ? characters8()[i] : characters16()[i];
 }
 
 inline UChar RenderText::characterAt(unsigned i) const
 {
     if (i >= textLength())
         return 0;
 
     return uncheckedCharacterAt(i);
 }
 
 DEFINE_RENDER_OBJECT_TYPE_CASTS(RenderText, isText());
 
 #ifdef NDEBUG
 inline void RenderText::checkConsistency() const
 {
 }
 #endif
 
 void applyTextTransform(const RenderStyle*, String&, UChar);
 
 } // namespace WebCore
 
 #endif // RenderText_h