Issue 11183028: Merge 130883 - Web Inspector: Semantically incorrect CSS rules result in broken source code data

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11183028: Merge 130883 - Web Inspector: Semantically incorrect CSS rules result in broken source code data (Closed)

Created:
8 years, 2 months ago by apavlov

Modified:
8 years, 2 months ago

Reviewers:
apavlov

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/

Visibility:
Public.

More Reviews

Description

Merge 130883 - Web Inspector: Semantically incorrect CSS rules result in broken source code data https://bugs.webkit.org/show_bug.cgi?id=98520 Reviewed by Vsevolod Vlasov. Source/WebCore: Pop and throw away rule data from the stack when data have been collected for a semantically invalid CSS rule (which is not going to be created). * css/CSSParser.cpp: (WebCore::CSSParser::createImportRule): (WebCore::CSSParser::createFontFaceRule): (WebCore::CSSParser::createPageRule): (WebCore::CSSParser::createRegionRule): TBR=apavlov@chromium.org Committed: https://trac.webkit.org/changeset/131566

Patch Set 1 #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	Source/WebCore/css/CSSParser.cpp	View		4 chunks	+9 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages