Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Unified Diff: content/common/frame_messages.h

Issue 1118083004: Revert of OOPIF: Specify previous sibling frames when creating new RenderFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/frame_messages.h
diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h
index 7783f75febe2a62514c2f0348ec1819d257005ee..70870ab2f77d9c535b4b1eb73ce07755bfa00bbd 100644
--- a/content/common/frame_messages.h
+++ b/content/common/frame_messages.h
@@ -298,35 +298,6 @@
IPC_STRUCT_MEMBER(bool, hidden)
IPC_STRUCT_END()
-IPC_STRUCT_BEGIN(FrameMsg_NewFrame_Params)
- // Specifies the routing ID of the new RenderFrame object.
- IPC_STRUCT_MEMBER(int, routing_id)
-
- // The new frame should be created as a child of the object
- // identified by |parent_routing_id| or as top level if that is
- // MSG_ROUTING_NONE.
- IPC_STRUCT_MEMBER(int, parent_routing_id)
-
- // Identifies the previous sibling of the new frame, so that the new frame is
- // inserted into the correct place in the frame tree. If this is
- // MSG_ROUTING_NONE, the frame will be created as the leftmost child of its
- // parent frame, in front of any other children.
- IPC_STRUCT_MEMBER(int, previous_sibling_routing_id)
-
- // If a valid |proxy_routing_id| is provided, the new frame will be
- // configured to replace the proxy on commit.
- IPC_STRUCT_MEMBER(int, proxy_routing_id)
-
- // When the new frame has a parent, |replication_state| holds the new frame's
- // properties replicated from the process rendering the parent frame, such as
- // the new frame's sandbox flags.
- IPC_STRUCT_MEMBER(content::FrameReplicationState, replication_state)
-
- // Specifies properties for a new RenderWidget that will be attached to the
- // new RenderFrame (if one is needed).
- IPC_STRUCT_MEMBER(FrameMsg_NewFrame_WidgetParams, widget_params)
-IPC_STRUCT_END()
-
IPC_STRUCT_BEGIN(FrameHostMsg_OpenURL_Params)
IPC_STRUCT_MEMBER(GURL, url)
IPC_STRUCT_MEMBER(content::Referrer, referrer)
@@ -418,8 +389,19 @@
// commit, activation and frame swap of the current DOM tree in blink.
IPC_MESSAGE_ROUTED1(FrameMsg_VisualStateRequest, uint64 /* id */)
-// Instructs the renderer to create a new RenderFrame object.
-IPC_MESSAGE_CONTROL1(FrameMsg_NewFrame, FrameMsg_NewFrame_Params /* params */);
+// Instructs the renderer to create a new RenderFrame object with |routing_id|.
+// The new frame should be created as a child of the object identified by
+// |parent_routing_id| or as top level if that is MSG_ROUTING_NONE.
+// If a valid |proxy_routing_id| is provided, the new frame will be configured
+// to replace the proxy on commit. When the new frame has a parent,
+// |replication_state| holds properties replicated from the process rendering
+// the parent frame, such as the new frame's sandbox flags.
+IPC_MESSAGE_CONTROL5(FrameMsg_NewFrame,
+ int /* routing_id */,
+ int /* parent_routing_id */,
+ int /* proxy_routing_id */,
+ content::FrameReplicationState /* replication_state */,
+ FrameMsg_NewFrame_WidgetParams /* widget_params */)
// Instructs the renderer to create a new RenderFrameProxy object with
// |routing_id|. The new proxy should be created as a child of the object
« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/renderer/render_frame_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698