Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Unified Diff: content/renderer/render_frame_impl.h

Issue 1118083004: Revert of OOPIF: Specify previous sibling frames when creating new RenderFrames. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/frame_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 53eea0cfe07e06e624b817205ad817d04266bbda..0046c35071b46e922926faea9befdec48f6702b4 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -130,16 +130,14 @@
// Creates a new RenderFrame with |routing_id| as a child of the RenderFrame
// identified by |parent_routing_id| or as the top-level frame if the latter
// is MSG_ROUTING_NONE. If |proxy_routing_id| is MSG_ROUTING_NONE, it creates
- // the Blink WebLocalFrame and inserts it into the frame tree after the frame
- // identified by |previous_sibling_routing_id|, or as the first child if
- // |previous_sibling_routing_id| is MSG_ROUTING_NONE. Otherwise, the frame is
- // semi-orphaned until it commits, at which point it replaces the proxy
- // identified by |proxy_routing_id|. Note: This is called only when
- // RenderFrame is being created in response to IPC message from the browser
- // process. All other frame creation is driven through Blink and Create.
+ // the Blink WebLocalFrame and inserts it in the proper place in the frame
+ // tree. Otherwise, the frame is semi-orphaned until it commits, at which
+ // point it replaces the proxy identified by |proxy_routing_id|.
+ // Note: This is called only when RenderFrame is being created in response to
+ // IPC message from the browser process. All other frame creation is driven
+ // through Blink and Create.
static void CreateFrame(int routing_id,
int parent_routing_id,
- int previous_sibling_routing_id,
int proxy_routing_id,
const FrameReplicationState& replicated_state,
CompositorDependencies* compositor_deps,
« no previous file with comments | « content/common/frame_messages.h ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698