Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1117953005: Remove FileSystem runtime flag for chromium (Closed)

Created:
5 years, 7 months ago by qiankun
Modified:
5 years, 7 months ago
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FileSystem runtime flag for chromium This feature is in stable status since 2013. It should be fine to remove this runtime flag. The blink side patch is at: https://codereview.chromium.org/1117063005/ BUG=402536

Patch Set 1 #

Patch Set 2 : remove all kDisableFileSystem #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M android_webview/lib/main/aw_main_delegate.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/runtime_features.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
qiankun
PTAL.
5 years, 7 months ago (2015-05-04 06:31:32 UTC) #2
Mike West
On 2015/05/04 at 06:31:32, qiankun.miao wrote: > PTAL. Please remove the usage in android_webview/lib/main/aw_main_delegate.cc as ...
5 years, 7 months ago (2015-05-04 14:20:14 UTC) #3
Avi (use Gerrit)
lgtm stampity stamp
5 years, 7 months ago (2015-05-04 14:29:56 UTC) #4
qiankun
On 2015/05/04 14:20:14, Mike West (traveling. slow.) wrote: > On 2015/05/04 at 06:31:32, qiankun.miao wrote: ...
5 years, 7 months ago (2015-05-04 15:19:04 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117953005/20001
5 years, 7 months ago (2015-05-04 15:38:33 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/60838)
5 years, 7 months ago (2015-05-04 15:44:46 UTC) #10
qiankun
Torne@, could you do owner review for src/android_webview/?
5 years, 7 months ago (2015-05-04 17:19:24 UTC) #12
Torne
not LGTM. The flag is used by WebView; please don't just remove where we set ...
5 years, 7 months ago (2015-05-05 08:48:11 UTC) #13
qiankun
5 years, 7 months ago (2015-05-05 09:22:32 UTC) #14
On 2015/05/05 08:48:11, Torne wrote:
> not LGTM. The flag is used by WebView; please don't just remove where we set
it.
> The comment with the flag mentions possibly needing new APIs to allow the
> embedder to control the filesystem API and I think we still need to consider
> this. Also, have you tested that the filesystem API actually even works in
> webview?

Thanks for review. Yes, WebView is still using this flag to disable FileSystem.
Sorry, my mistake for omitting the check.

Powered by Google App Engine
This is Rietveld 408576698