Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1117753005: Replace v8::Handle with v8::Local in Source/bindings/* (Closed)

Created:
5 years, 7 months ago by deepak.s
Modified:
5 years, 7 months ago
Reviewers:
haraken, vivekg
CC:
blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Replace v8::Handle with v8::Local in Source/bindings/* Handle is an alias of local. BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194705

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/modules/v8/SerializedScriptValueForModulesFactory.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/modules/v8/ToV8ForModules.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
deepak.s
PTAL? Thanks!
5 years, 7 months ago (2015-04-30 05:25:27 UTC) #2
vivekg
LGTM
5 years, 7 months ago (2015-04-30 05:26:18 UTC) #3
haraken
LGTM
5 years, 7 months ago (2015-04-30 05:30:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1117753005/1
5 years, 7 months ago (2015-04-30 05:57:25 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 07:28:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194705

Powered by Google App Engine
This is Rietveld 408576698